test(frontend): add spec for VisualizationFrameContentComponent#5585
Open
EmilySun621 wants to merge 1 commit into
Open
test(frontend): add spec for VisualizationFrameContentComponent#5585EmilySun621 wants to merge 1 commit into
EmilySun621 wants to merge 1 commit into
Conversation
Covers drawChart() guard clauses (no-op when operatorId is undefined, when the result service is missing, or when the snapshot is empty), the rendering path (renders the latest entry's html-content through DomSanitizer into the iframe srcdoc), and the auditTime-throttled result-update subscription (redraws after UPDATE_INTERVAL_MS for matching ids, ignores other ids and undefined operatorId). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5585 +/- ##
============================================
+ Coverage 52.17% 52.25% +0.07%
Complexity 2482 2482
============================================
Files 1068 1068
Lines 41311 41311
Branches 4439 4439
============================================
+ Hits 21556 21588 +32
+ Misses 18490 18455 -35
- Partials 1265 1268 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Adds a behavior-focused unit test spec for
VisualizationFrameContentComponent. Tests cover:drawChart()guard clauses (no-op when data is missing)srcdocauditTime-throttled subscription (tested withfakeAsync/tick)Any related issues, documentation, discussions?
Related to #5601
How was this PR tested?
Spec verified with
npx ng test --watch=false --include='**/visualization-frame-content.component.spec.ts'. 7 tests passing.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Anthropic)