Repository navigation
refactor(frontend): remove the dead admin Gmail stylesheet - #9027
Open
aglinxinyuan wants to merge 1 commit into
Open
aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
The stylesheet's only rule, .form, has never matched anything: the Gmail template has no element with class "form" (its <form nz-form> gets only ant-form* classes), and emulated encapsulation keeps the rule from reaching any other template. Delete the file and its styleUrls entry.
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9027 +/- ##
=========================================
Coverage 92.33% 92.33%
Complexity 5045 5045
=========================================
Files 1261 1261
Lines 54120 54120
Branches 6768 6768
=========================================
Hits 49970 49970
Misses 2488 2488
Partials 1662 1662
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
Review effort: Lite
kunwp1
approved these changes
Oct 20, 2026
Copilot stopped reviewing on behalf of
kunwp1 due to an error
October 20, 2026 20:16
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes
admin-gmail.component.scssand itsstyleUrlsentry inadmin-gmail.component.ts. −27 lines. There is no behaviour change.The stylesheet's only rule is
.form { ... }. The component uses emulated encapsulation, so the rule can only match an element in its own template, and that template has no element with classform. The<form nz-form>element doesn't match:.formis a class selector, andNzFormDirectiveadds onlyant-form*classes. Nothing else references the file (angular.jsonstyles,@use,@import). With no styles left, Angular compiles the component without view emulation, so the rendered DOM only loses the generated_ngcontentattributes.History
.formfrom the login stylesheet into the new componentformclassIt has never applied, in the three years since it was added.
Any related issues, documentation, discussions?
Closes #9024
How was this PR tested?
No new tests; the spec never referenced the stylesheet.
From
frontend/:npx ng test --watch=false --include='**/admin-gmail.component.spec.ts': 10 tests, all pass. No other spec renders the component.yarn format:ci: clean.npx ng build: success.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code