Skip to content

refactor(frontend): remove the dead admin Gmail stylesheet - #9027

Open
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:refactor/fe-admin-gmail-dead-stylesheet
Open

aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:refactor/fe-admin-gmail-dead-stylesheet

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Deletes admin-gmail.component.scss and its styleUrls entry in admin-gmail.component.ts. −27 lines. There is no behaviour change.

The stylesheet's only rule is .form { ... }. The component uses emulated encapsulation, so the rule can only match an element in its own template, and that template has no element with class form. The <form nz-form> element doesn't match: .form is a class selector, and NzFormDirective adds only ant-form* classes. Nothing else references the file (angular.json styles, @use, @import). With no styles left, Angular compiles the component without view emulation, so the rendered DOM only loses the generated _ngcontent attributes.

History

Introduced by #2027 (2023-10-11), "Introduce Email Notification System". It copied .form from the login stylesheet into the new component
Usage removed by never used. No version of the Gmail template has had a form class

It has never applied, in the three years since it was added.

Any related issues, documentation, discussions?

Closes #9024

How was this PR tested?

No new tests; the spec never referenced the stylesheet.

From frontend/:

  • npx ng test --watch=false --include='**/admin-gmail.component.spec.ts': 10 tests, all pass. No other spec renders the component.
  • yarn format:ci: clean.
  • npx ng build: success.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with Claude Code

The stylesheet's only rule, .form, has never matched anything: the
Gmail template has no element with class "form" (its <form nz-form>
gets only ant-form* classes), and emulated encapsulation keeps the
rule from reaching any other template. Delete the file and its
styleUrls entry.
Copilot AI balanced review requested due to automatic review settings October 19, 2026 07:07
@aglinxinyuan aglinxinyuan self-assigned this Oct 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added refactor Refactor the code frontend Changes related to the frontend GUI labels Oct 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @Yicong-Huang
    You can notify them by mentioning @Yicong-Huang in a comment.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.33%. Comparing base (a46ddc6) to head (0004835).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9027   +/-   ##
=========================================
  Coverage     92.33%   92.33%           
  Complexity     5045     5045           
=========================================
  Files          1261     1261           
  Lines         54120    54120           
  Branches       6768     6768           
=========================================
  Hits          49970    49970           
  Misses         2488     2488           
  Partials       1662     1662           
Flag Coverage Δ *Carryforward flag
access-control-service 77.38% <ø> (ø) Carriedforward from a46ddc6
agent-service 99.16% <ø> (ø) Carriedforward from a46ddc6
amber 87.31% <ø> (ø) Carriedforward from a46ddc6
computing-unit-managing-service 60.48% <ø> (ø) Carriedforward from a46ddc6
config-service 87.37% <ø> (ø) Carriedforward from a46ddc6
file-service 82.00% <ø> (ø) Carriedforward from a46ddc6
frontend 96.55% <ø> (ø)
notebook-migration-service 83.73% <ø> (ø) Carriedforward from a46ddc6
pyamber 98.51% <ø> (ø) Carriedforward from a46ddc6
workflow-compiling-service 72.43% <ø> (ø) Carriedforward from a46ddc6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aglinxinyuan
aglinxinyuan requested a review from kunwp1 October 19, 2026 21:06
@kunwp1
kunwp1 requested a lite review from Copilot October 20, 2026 17:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

No open issues 🎉

Review effort: Lite

@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 21, 2026
@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 21, 2026
@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Oct 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI refactor Refactor the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the dead admin Gmail stylesheet

4 participants