Skip to content

refactor(frontend): remove the unused GenericWebResponse types - #9071

Queued
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:refactor/fe-generic-web-response
Queued

aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:refactor/fe-generic-web-response

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Deletes frontend/src/app/common/type/generic-web-response.ts, a type file nothing imports. −32 lines. There is no behaviour change.

The file exports GenericWebResponse and GenericWebResponseCode. No code, spec, barrel file or path alias references the file or either symbol, and no open PR adds an import.

History

Introduced by #752 (2020-05-15), "User System Frontend Part": the interface. #757 (2020-06-05), "User System Dictionary Uploading", added the enum
Usage removed by #1470 (2022-05-19), "Change Login component to use ng-zorro instead of bootstrap. Remove unused components". It removed the last readers

It has been unused for over four years.

Any related issues, documentation, discussions?

Closes #9068

How was this PR tested?

No new tests; nothing referenced the file.

From frontend/:

  • npx tsc --noEmit -p src/tsconfig.app.json and npx tsc --noEmit -p src/tsconfig.spec.json: clean.
  • yarn format:ci: clean.
  • npx ng build: success.

To re-check:

git grep -n -i -e GenericWebResponse -e generic-web-response   # no hits

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with Claude Code

Nothing has imported common/type/generic-web-response.ts since apache#1470
removed its last readers. Delete the file.
@aglinxinyuan aglinxinyuan self-assigned this Oct 21, 2026
Copilot AI balanced review requested due to automatic review settings October 21, 2026 04:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aglinxinyuan
aglinxinyuan requested a review from kunwp1 October 21, 2026 04:16
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

@github-actions github-actions Bot added refactor Refactor the code frontend Changes related to the frontend GUI labels Oct 21, 2026
@kunwp1
kunwp1 requested a lite review from Copilot October 21, 2026 06:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

No open issues 🎉

Review effort: Lite

@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI refactor Refactor the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the unused GenericWebResponse type file

3 participants