Repository navigation
refactor(frontend): remove the unused GenericWebResponse types - #9071
Queued
aglinxinyuan wants to merge 1 commit into
Queued
aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Nothing has imported common/type/generic-web-response.ts since apache#1470 removed its last readers. Delete the file.
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
Review effort: Lite
kunwp1
approved these changes
Oct 21, 2026
Copilot stopped reviewing on behalf of
kunwp1 due to an error
October 21, 2026 06:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes
frontend/src/app/common/type/generic-web-response.ts, a type file nothing imports. −32 lines. There is no behaviour change.The file exports
GenericWebResponseandGenericWebResponseCode. No code, spec, barrel file or path alias references the file or either symbol, and no open PR adds an import.History
It has been unused for over four years.
Any related issues, documentation, discussions?
Closes #9068
How was this PR tested?
No new tests; nothing referenced the file.
From
frontend/:npx tsc --noEmit -p src/tsconfig.app.jsonandnpx tsc --noEmit -p src/tsconfig.spec.json: clean.yarn format:ci: clean.npx ng build: success.To re-check:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code