TEZ-4754: RelocalizationUtils: input handling improvements - #537
Open
abstractdog wants to merge 1 commit into
Open
abstractdog wants to merge 1 commit into
abstractdog wants to merge 1 commit into
Conversation
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
🟡 Changes recommended
URI-scheme traversal and submission-state corruption remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Tightens destination filename validation for relocalized AM resources and adds unit coverage.
Changes:
- Rejects empty, path-based, absolute, and traversal-like names.
- Adds tests for valid and invalid destination names.
File summaries
| File | Description |
|---|---|
tez-common/src/test/java/org/apache/tez/dag/utils/TestRelocalizationUtils.java |
Adds coverage for accepted and rejected destination names. |
tez-common/src/main/java/org/apache/tez/dag/utils/RelocalizationUtils.java |
Validates destination names before downloading resources. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+82
to
+91
| if (destName.indexOf('/') >= 0 || destName.indexOf('\\') >= 0 | ||
| || destName.indexOf('\0') >= 0) { | ||
| throw new IllegalArgumentException( | ||
| "Resource name must not contain path separators: " + destName); | ||
| } | ||
| if (destName.equals(".") || destName.equals("..")) { | ||
| throw new IllegalArgumentException( | ||
| "Resource name must not be a parent-directory reference: " + destName); | ||
| } | ||
| if (new Path(destName).isAbsolute()) { |
Contributor
Author
There was a problem hiding this comment.
not true, adding a unit test to prove: uriSchemeOpaqueFormIsRejected
new Path(destName) call inside RelocalizationUtils#validateDestName already throwsIllegalArgumentException from Hadoop's URI parser in such cases
| // absolute path, a path separator, or a ".." segment — so a submitter | ||
| // holding AM modify access cannot land a jar anywhere on the AM host and | ||
| // chain it into code execution via the classloader / am-hooks path. | ||
| validateDestName(destName); |
Contributor
Author
There was a problem hiding this comment.
ack, handling with an upfront check
abstractdog
force-pushed
the
TEZ-4754
branch
from
September 21, 2026 10:15
d42ada8 to
650be89
Compare
Tighten validation of the destination file name used when downloading additional AM resources so unexpected shapes are rejected before the file is written. Adds a small unit test. Co-Authored-By: Claude Code <noreply@anthropic.com>
abstractdog
force-pushed
the
TEZ-4754
branch
from
September 21, 2026 11:11
650be89 to
5ce77fb
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tighten validation of the destination file name used when downloading additional AM resources so unexpected shapes are rejected before the file is written. Adds a small unit test.