Conversation
- Weird endpoint changes to allow flexibility when editing TLS configuration. TODO: - Missing List<UpgradeProtocol> upgradeProtocols configuration (only specialized HTTP/2 support is really needed in practice). - Add a "Restart" button (which would do a Stop followed by a Start for all components that implement Lifecycle. Not all attribute changes take effect without at least a restart (which attributes work "live" is rather undocumented), so this is needed after certain changes.
Tested on a phone in portrait or landscape mode. The only really not so nice item is the icon row.
Also redo the icons and the bar scaling. Add some accent colors.
Much needed for logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new more modern manager/admin webapp for Tomcat. The webapp is currently located in
modules/manager2. This includes a testsuite.What it is:
What it is not:
Use
antto build,ant deployto put it in theoutput/build/webappsof the main folder to be able to run it, andant testto run the tests (which takes time, basically most of the tests use a different config, some test deployment, edit and save to server.xml, so it's hard to avoid it even if I wanted to).Please keep PR review focused on essentials: