Conversation
This was referenced Oct 4, 2026
oraluben
marked this pull request as ready for review
October 4, 2026 06:41
This was referenced Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROCm device existence checks directly include
hsa/hsa.hand call HSA initialization/shutdown around a HIP query. The tested Windows ROCm 10.0 pip SDK omits that header, preventing compilation, although its HIP DLL exports working HSA functions.Use
hipGetDeviceCounton Linux and Windows. HIP automatically initializes its runtime; on the ROCr path this includes HSA initialization and cleanup. Removing TVM's extra HSA reference does not bypass that initialization. Return false on HIP errors or invalid ordinals, remove unused HSA discovery/linkage, and add portable device-query regressions.Validation:
Linux GPU execution and a full upstream compiler build were not tested. Mirror: tile-ai#79. Consumer: tile-ai/tilelang#3425.