Skip to content

[ZEPPELIN-6512] Fix typos in variable names and log messages in terminal classes#5286

Open
ParkGyeongTae wants to merge 1 commit into
apache:masterfrom
ParkGyeongTae:ZEPPELIN-6512
Open

[ZEPPELIN-6512] Fix typos in variable names and log messages in terminal classes#5286
ParkGyeongTae wants to merge 1 commit into
apache:masterfrom
ParkGyeongTae:ZEPPELIN-6512

Conversation

@ParkGyeongTae

Copy link
Copy Markdown
Member

What is this PR for?

Fix typos in variable/parameter names and log messages across the terminal interpreter classes.
The changes are purely cosmetic — no logic is altered.

  • Cann'tCan't in log messages (TerminalManager.java, 4 occurrences)
  • UnrecodnizedUnrecognized in log message (TerminalSocket.java)
  • allwedOriginallowedOrigin for field and parameter names (TerminalThread.java)
  • keyPrexkeyPrefix for local variable name (TerminalManager.java)
  • nodeIdnoteId for parameter name to match actual semantics (TerminalManager.java)

What type of PR is it?

Improvement

Todos

  • Fix typos in log messages
  • Fix typos in variable/field/parameter names
  • Correct semantic naming (nodeIdnoteId)

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-6512

How should this be tested?

No logic changes are made. Verify that the terminal interpreter starts and operates normally:

  1. Launch Zeppelin with the Shell interpreter.
  2. Open a note and run a %sh.terminal paragraph.
  3. Confirm the terminal connects and responds without errors.

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@devyeony

Copy link
Copy Markdown
Contributor

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants