[ZEPPELIN-6519] Add e2e/AGENTS.md conventions and scope the coverage denominator#5290
Open
voidmatcha wants to merge 1 commit into
Open
[ZEPPELIN-6519] Add e2e/AGENTS.md conventions and scope the coverage denominator#5290voidmatcha wants to merge 1 commit into
voidmatcha wants to merge 1 commit into
Conversation
…minator Add e2e/AGENTS.md as the shared source of truth for the zeppelin-web-angular Playwright E2E suite: tooling (e2e-skills), layout and POM split, locator order, web-first assertions, readiness/auth, the required coverage annotation, run commands, and forward guidance for the Angular to React microfrontend migration (the react flag is per-route and read from ActivatedRoute.queryParams, so it belongs inside the hash; add a spec-scoped parity project only when a route actually reads it). Scope the coverage denominator to page-level components: PAGES doubles as the coverage-instrumentation set (getCoverageTransformPaths), so drop four structural/shared components (destroy-hook, page-header, resize-handle, spin) that have no page-level behavior and are exercised transitively. Denominator goes 57 -> 53. Constraint: RAT license header on the new committed file. Confidence: high Scope-risk: none (documentation plus a coverage-set trim; no runtime code changed) Not-tested: e2e not run (node_modules-driven hooks skipped with --no-verify due to a pre-existing unused catch binding in unrelated code, outside this change)
voidmatcha
force-pushed
the
improve/e2e-conventions-and-coverage
branch
from
ad491f5 to
dc6349e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The
zeppelin-web-angularE2E suite had no written authoring conventions, and the coverage denominator counted components that are not page-level. This addse2e/AGENTS.mdas the shared conventions doc: tooling, POM layout, locator order, web-first assertions, readiness and auth, the required coverage annotation, run commands, and guidance for the Angular to React migration. It also trimsPAGESine2e/utils.tsto page-level components so coverage measures what is actually E2E-targetable. Four structural or shared components (destroy-hook, page-header, resize-handle, spin) are removed, so the denominator changes from 57 to 53. This is documentation plus a coverage-set trim, with no runtime code changes.What type of PR is it?
Improvement / Documentation
What is the Jira issue?
ZEPPELIN-6519
How should this be tested?
e2e/AGENTS.mdis documentation. For theutils.tschange, runnpm run e2e(ornpm run e2e:fast). Coverage attribution for existing pages is unchanged, and the four removed components are still exercised transitively.Questions: