[ZEPPELIN-6685] Resolve the app's imports in the shell unit test setup - #5439
Open
voidmatcha wants to merge 1 commit into
Open
[ZEPPELIN-6685] Resolve the app's imports in the shell unit test setup#5439voidmatcha wants to merge 1 commit into
voidmatcha wants to merge 1 commit into
Conversation
voidmatcha
force-pushed
the
vitest-shell-alias
branch
from
August 27, 2026 16:33
65319bf to
3240e81
Compare
jongyoul
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
vitest.shell.config.mtsdeclares noresolve.alias, and Vite does not read thepathsblock intsconfig.base.json, so a spec cannot reach application source:The failure is in the source, not the spec: most of
src/imports@zeppelin/*itself, so a relative import does not avoid it.monaco-editordoes not resolve either. It publishes nomainand noexports(monaco-editor#4848);modulenameseditor.main, which boots the full editor and fails under jsdom. Eleven files import it, two behind the@zeppelin/servicesbarrel.This adds the alias block, a spec that exercises it, and a note in
AGENTS.md. Two entries differ fromtsconfig.base.json:@zeppelin/sdkand@zeppelin/visualizationresolve to library source, notdist/, so a unit run does not wait on a build.projects/zeppelin-react/vitest.config.mtsalready does this for the SDK.monaco-editorresolves toesm/vs/editor/editor.api.js.What type of PR is it?
Improvement
Todos
None
What is the Jira issue?
ZEPPELIN-6685
How should this be tested?
npm run test:shellgoes from 29 tests to 37. The new spec coversArrayOrderingService: trash folder last, blank title falls back toNote <id>, folders before notes, same-kind nodes by display name.It imports through the
@zeppelin/servicesbarrel so the chain reaches monaco and@zeppelin/sdk. Pointing any ofmonaco-editor,@zeppelin/sdkor the catch-all at a nonexistent path fails it. Nothing imports thesdk/*orvisualization/*subpaths today, so those two are uncovered.ng build --configuration productionandng lintboth pass unchanged: only Vitest reads the config, andsrc/tsconfig.jsonexcludes specs from the build.Screenshots (if appropriate)
N/A
Questions: