ZOOKEEPER-5091: WatchManager reports connections with no active watches after consuming the last standard watch - #2457
Open
casolaroSalvatore wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When the last STANDARD watch associated with a watcher is triggered, WatchManager removes the path registration but retains an empty entry in watch2Paths. As a result, getWatchesSummary() reports one connection with zero paths and zero watches, while getWatches() reports the session with an empty path set.
Change
Remove the watcher from watch2Paths when its last STANDARD watch is consumed and the associated path map becomes empty. The cleanup is performed only when the path map is empty, so other registrations belonging to the same watcher are preserved.
Testing
Regression tests verify that:
Validation performed locally:
JIRA: ZOOKEEPER-5091
This issue was identified while working on an academic software testing project provided within a course taught by Prof. Guglielmo De Angelis (@gulyx) at the University of Rome Tor Vergata.