Repository navigation
Conversation
…nd task run The flag was forwarded only when truthy, so `--timeout 0` was dropped and the run got the Actor's default timeout instead of none. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VTFswSQJstnQ6r8QeqfgK
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation correctly distinguishes zero from an omitted flag and is comprehensively tested.
0 open findings
What changed in this PR
Fixes zero-timeout handling for cloud Actor and Task runs.
Changes:
- Forwards explicit
--timeout 0while preserving omitted-timeout behavior. - Adds parameterized coverage for all three affected commands.
| File | Description |
|---|---|
src/commands/actors/call.ts |
Preserves explicit zero timeout. |
src/commands/actors/start.ts |
Preserves explicit zero timeout. |
src/commands/task/run.ts |
Preserves explicit zero timeout. |
test/local/commands/run-timeout-flag.test.ts |
Tests zero, positive, and omitted timeouts. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pijukatel
marked this pull request as ready for review
October 12, 2026 12:03
apify-service-account
added
the
tested
apify-service-account
added
the
t-tooling
Contributor
Author
|
Unrelated e2e test failures are already present on master
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apify call --timeout 0,apify actors start --timeout 0andapify task run --timeout 0silently dropped the flag: it was only forwarded when truthy, so the run got the Actor's default timeout instead of none, even though the flag's help text promises "zero value means there is no timeout".0sent as0, positive sent as is, omitted not sent).