Repository navigation
test: serve the whole-log fallback in the streamed log mocks - #1114
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
- Coverage 95.50% 95.46% -0.04%
==========================================
Files 61 61
Lines 5935 5935
==========================================
- Hits 5668 5666 -2
- Misses 267 269 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 11, 2026 21:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky
test_actor_call_redirect_logs_to_default_logger_async[httpx2](failed run).When
call()finishes before the log stream delivers its first chunk,StreamedLogreads the whole log withGET /log?raw=true(added in #1084). Themock_apiandmock_api_failing_status_pollfixtures didn't serve that endpoint. Intest_actor_call_returns_run_when_status_poll_fails_sync, the sync thread then retried the 500 with backoff, outlived the 5 s join instop(), and logged its error into the next test'scaplogon the same xdist worker.Both fixtures now serve the whole log on that endpoint. Locally the failure went from 2/10 to 0/40 with the two tests in CI order, and
test_logging.pyunder-n autopassed 30/30.✍️ Drafted by Claude Code