chore: consume the apify/vale-rules package instead of local styles - #2870
Draft
TC-MO wants to merge 1 commit into
Draft
chore: consume the apify/vale-rules package instead of local styles#2870TC-MO wants to merge 1 commit into
TC-MO wants to merge 1 commit into
Conversation
Pin v1.0.0 and remove the nine local Apify rules. vale sync replaces the whole directory, so the four synced dirs are gitignored and ImageAltText.yml is untracked rather than deleted. Add ApifyDocs to BasedOnStyles and rename Apify.H1 to ApifyDocs.H1, because four rules moved styles and Vale ignores an unknown override silently. Errors stay at 12 on the same lines across sources/platform and academy. Deferred: TechnologyNames misses the VSCode casing, and ActorCapitalization is a suggestion where Capitalization was an error.
Contributor
|
✅ Preview for this PR (commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin v1.0.0 and remove the nine local Apify rules. vale sync replaces the whole directory, so the four synced dirs are gitignored and ImageAltText.yml is untracked rather than deleted.
Add ApifyDocs to BasedOnStyles and rename Apify.H1 to ApifyDocs.H1, because four rules moved styles and Vale ignores an unknown override silently.
Errors stay at 12 on the same lines across sources/platform and academy. Deferred: TechnologyNames misses the VSCode casing, and ActorCapitalization is a suggestion where Capitalization was an error.