fix(dataset): preserve push_data compatibility with the released Apify SDK - #2152
Merged
Conversation
…or released Apify SDK versions
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2152 +/- ##
==========================================
+ Coverage 93.62% 93.64% +0.02%
==========================================
Files 181 181
Lines 12649 12653 +4
==========================================
+ Hits 11842 11849 +7
+ Misses 807 804 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DatasetClient._is_sequence_of_items for released Apify SDK versions
vdusek
marked this pull request as ready for review
August 12, 2026 09:22
Pijukatel
approved these changes
Aug 12, 2026
Pijukatel
self-requested a review
August 12, 2026 11:21
Pijukatel
reviewed
Aug 12, 2026
Pijukatel
left a comment
Collaborator
There was a problem hiding this comment.
Stagehand templates are still failing (Maybe another issue)
https://github.com/apify/crawlee-python/actions/runs/31583394515/job/94071500831
Collaborator
Author
|
Stagehand:
So it's not related to this one, I'll resolve it as separate PR, and same for the alerting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled E2E tests fail on every matrix job (all 90) with:
DatasetClient._is_sequence_of_itemswas removed in #2145. The released Apify SDK (up to 4.0.1) still calls it fromApifyDatasetClient.push_data, inheriting it from this base class, so a master wheel paired with the published SDK raises on everypush_data. The templates E2E test builds exactly that pairing. Published crawlee 1.9.1 predates the removal, so this is not only a CI problem: the next crawlee release would carry the same break to every Actor resolvingapify<=4.0.1.This restores the helper on
DatasetClient, annotated-> boolrather thanTypeIs[...]. The narrowing is whatty 0.0.69objected to in the first place, and nopush_dataimplementation here uses the helper anymore, they keep the inlinedisinstance. Drop it in the next major version, once those SDK versions are out of the supported range.Verified by installing the built wheel alongside
apify==4.0.1and confirming the SDK call site resolves; swapping in the unpatched base class reproduces the failure above.Failing run: https://github.com/apify/crawlee-python/actions/runs/31554176158
✍️ Drafted by Claude Code