fix: scope xcodebuild process kill to this package's own processes - #1244
Merged
Conversation
resetTestProcesses() previously matched any xcodebuild process whose command line referenced the target device udid, which could kill unrelated XCTest runners (e.g. a separately managed WebDriverAgent instance) targeting the same device. Every xcodebuild invocation this package starts now carries a marker build setting, and the kill logic only terminates xcodebuild processes carrying it. Fixes appium/appium#13426
Renames APPIUM_XCUITEST_DRIVER_WDA_MARKER to APPIUM_XCODEBUILD_WDA_MARKER and fixes an import ordering issue flagged by oxfmt.
KazuCocoa
approved these changes
Sep 1, 2026
|
🎉 This PR is included in version 16.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resetTestProcesses() previously matched any xcodebuild process whose command line referenced the target device udid, which could kill unrelated XCTest runners (e.g. a separately managed WebDriverAgent instance) targeting the same device. Every xcodebuild invocation this package starts now carries a marker build setting, and the kill logic only terminates xcodebuild processes carrying it.
Fixes appium/appium#13426