Keep container logs writing after an attached client dies - #2046
Open
rogerneal wants to merge 1 commit into
Open
Keep container logs writing after an attached client dies#2046rogerneal wants to merge 1 commit into
rogerneal wants to merge 1 commit into
Conversation
Isolate per-handle failures in MultiWriter so an EPIPE from a dead client stdio handle cannot abort writes to the on-disk container log. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MultiWriterso a dead attached client (EPIPE) does not stop writes to the on-disk container log.MultiWriterinto its own file and add unit tests that reproduce the EPIPE fan-out failure.Fixes #2009
Test plan
Tested
swift test --filter MultiWriterTestswriteContinuesToLogAfterClientEPIPE: client pipe closed (EPIPE), log file still receives subsequent writeswriteThrowsWhenEveryHandleFails: throws when no handles remain writable/tmp:container run --name freeze alpine:latest sh -c 'while true; do echo "tick $(date -u +%H:%M:%S)"; sleep 2; done'before_count=3, lasttick 00:07:31)kill -9the attachedcontainer runPIDrunningcontainer logs freezeshowed 7 additional ticks throughtick 00:07:45(after_count=10)SIGPIPEthe same wayRuntimeLinuxHelperdoes, so broken-pipe writes surface as EPIPE