Document shell evaluation in container machine run - #2047
Open
amarkdotdev wants to merge 1 commit into
Open
Conversation
machine run joins the command and arguments and evaluates them with the guest user's shell (shell -c "$*"), including expansion and substitution. Document that contract in the CLI help and machine docs so it is not mistaken for argv-preserving behavior. Fixes apple#1954 Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
container machine runjoins<executable>and<arguments>and evaluates them through the guest user's shell (shell -c "$*"), including expansion, substitution, and redirection. That contract was easy to miss from--helpand the docs, especially for callers expecting argv-preserving behavior likedocker exec.This update documents the shell evaluation behavior in the machine guide, command reference, and CLI help.
Fixes #1954
Testing
Docs-only change; verified wording against
Sources/Plugins/MachineAPIServer/Resources/initand the existingtestRunWithEnvironment/testRunCommandInShellcoverage.