Skip to content

fix(deps): upgrade vitest to 4 in all three lockfiles - #50

Merged
ChiragAgg5k merged 1 commit into
mainfrom
fix/vitest-4
Nov 4, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
fix/vitest-4

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

Why

arena is on vitest 3.2.4, which is affected by the critical GHSA-5xrq-8626-4rwp and by GHSA-82fw-gwwq-j7x9. Renovate's #45 can't merge: it conflicts with main, and its npm relock dropped nitro's nested lru-cache, so npm ci fails on npm 10 with Missing: lru-cache@11.5.3 from lock file.

Fix

vitest moves to ^4.0.0, resolving to 4.1.12 in package-lock.json, pnpm-lock.yaml and bun.lock. The nested lru-cache entry stays in package-lock.json.

Testing

  • pnpm install --frozen-lockfile with pnpm 10, which is what CI uses
  • pnpm run test and pnpm run build
  • npm ci --dry-run on npm 10.9.3 and npm 11.21.1

The repo has no test files, so vitest run --passWithNoTests only shows that vitest 4 starts with this config.

Supersedes #45.

vitest below 4.1.11 is affected by GHSA-82fw-gwwq-j7x9 and below 3.2.6 by the critical GHSA-5xrq-8626-4rwp. Renovate's npm relock dropped nitro's nested lru-cache, which broke npm ci on npm 10, so this keeps that entry.
@ghost

ghost commented Nov 4, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

Frozen pnpm and Bun installs succeed, Vitest starts under the test script, and no removed Vitest API is used by this repository.

Vitest is upgraded from the 3.x line to 4.1.12, with the dependency manifest and npm, pnpm, and Bun lockfiles updated. The npm lockfile also retains Nitro's nested lru-cache entry while refreshing its locked version.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 4
File Change
package.json Raises the Vitest development dependency range to ^4.0.0.
bun.lock Updates the Bun dependency graph for Vitest 4 and its transitive dependencies.
package-lock.json Updates the npm dependency graph and retains Nitro's nested lru-cache entry.
pnpm-lock.yaml Updates the pnpm dependency graph for Vitest 4 and its transitive dependencies.

Reviewed 4dc0cdf · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k
ChiragAgg5k merged commit f11ecd7 into main Nov 4, 2026
4 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the fix/vitest-4 branch November 4, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant