Skip to content

api: fix snasphot-pull#1611

Open
tbe wants to merge 1 commit into
aptly-dev:masterfrom
tbe:api-pull-fix
Open

api: fix snasphot-pull#1611
tbe wants to merge 1 commit into
aptly-dev:masterfrom
tbe:api-pull-fix

Conversation

@tbe

@tbe tbe commented Jul 24, 2026

Copy link
Copy Markdown

in the API, snapshotPull never finished reading the target repository within the async block. So the target was treated as an empty snapshot, and a pull would only carry over the content from the sources

Fixes #1610

Description of the Change

This PR adds calls LoadComplete on freshToSnapshot.

Checklist

As this is a very minor change, i did not attribute myself in Authors.

  • allow Maintainers to edit PR (rebase, run coverage, help with tests, ...)
  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

in the API, snapshotPull never finished reading the target repository
within the async block. So the target was treated as an empty
snapshot, and a pull would only carry over the content from the sources
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.06%. Comparing base (f59b0d2) to head (f95153a).

Files with missing lines Patch % Lines
api/snapshot.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1611      +/-   ##
==========================================
- Coverage   77.37%   77.06%   -0.32%     
==========================================
  Files         165      165              
  Lines       15747    15750       +3     
==========================================
- Hits        12185    12137      -48     
- Misses       2356     2410      +54     
+ Partials     1206     1203       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API] snapshotPull produces wrong result

1 participant