Update theme colors and fonts to match armbian.com#902
Update theme colors and fonts to match armbian.com#902igorpecovnik wants to merge 1 commit intomainfrom
Conversation
Switch from red to Armbian orange (#F26522) brand color and use DM Sans / JetBrains Mono fonts to match the new website.
WalkthroughThe pull request updates the Armbian documentation site's styling configuration. CSS custom properties are added to define Armbian brand colors (primary and accent colors with variants) applied to the global Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/css/armbian-extra.css (1)
2-16: Consolidate duplicated token declarations.The
:rootandslateblocks are identical. Merging them into one selector list reduces drift risk.♻️ Refactor suggestion
-:root { - --md-primary-fg-color: `#F26522`; - --md-primary-fg-color--light: `#FF8B1A`; - --md-primary-fg-color--dark: `#DC5819`; - --md-accent-fg-color: `#F26522`; - --md-accent-fg-color--transparent: `#F2652218`; -} - -[data-md-color-scheme="slate"] { +:root, +[data-md-color-scheme="slate"] { --md-primary-fg-color: `#F26522`; --md-primary-fg-color--light: `#FF8B1A`; --md-primary-fg-color--dark: `#DC5819`; --md-accent-fg-color: `#F26522`; --md-accent-fg-color--transparent: `#F2652218`; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/css/armbian-extra.css` around lines 2 - 16, The two identical CSS blocks for :root and [data-md-color-scheme="slate"] should be consolidated into a single selector list to avoid duplicated token declarations; replace the two separate blocks with one combined selector (":root, [data-md-color-scheme=\"slate\"]") containing the shared custom properties (--md-primary-fg-color, --md-primary-fg-color--light, --md-primary-fg-color--dark, --md-accent-fg-color, --md-accent-fg-color--transparent) so the variables are defined once for both contexts.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/css/armbian-extra.css`:
- Around line 3-7: The :root and [data-md-color-scheme="slate"] theme blocks
define --md-primary-fg-color but omit --md-primary-bg-color, causing
insufficient contrast on primary surfaces; add an explicit --md-primary-bg-color
in both blocks (in :root set a dark-text background that pairs with the orange
foreground, e.g., a very light/neutral background color for normal text
readability, and in [data-md-color-scheme="slate"] set a dark background or
light text background appropriate for the dark scheme) so that
--md-primary-fg-color / --md-primary-bg-color meet WCAG AA (>=4.5:1) for normal
text. Ensure you add the variables alongside the existing --md-primary-fg-color
and --md-accent-fg-color declarations so the theme uses the explicit background
instead of the white default.
---
Nitpick comments:
In `@docs/css/armbian-extra.css`:
- Around line 2-16: The two identical CSS blocks for :root and
[data-md-color-scheme="slate"] should be consolidated into a single selector
list to avoid duplicated token declarations; replace the two separate blocks
with one combined selector (":root, [data-md-color-scheme=\"slate\"]")
containing the shared custom properties (--md-primary-fg-color,
--md-primary-fg-color--light, --md-primary-fg-color--dark, --md-accent-fg-color,
--md-accent-fg-color--transparent) so the variables are defined once for both
contexts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d1f5027a-08a4-4de5-9ad8-1e8b922d4441
📒 Files selected for processing (2)
docs/css/armbian-extra.cssmkdocs.yml
Summary
#F26522)Test plan
Documentation website preview will be available shortly:
Open WWW preview