Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df9dde40de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rustup toolchain install nightly | ||
| ``` | ||
|
|
||
| The development scripts also require Python 3.9 or later, Node.js, and the pnpm |
There was a problem hiding this comment.
A contributor using the newly documented minimum of Python 3.9 cannot run the documentation workflow: pnpm run build:docs invokes uv run --locked, while pyproject.toml:11 declares requires-python = ">=3.10". Document Python 3.10+ globally, or clarify that 3.9 supports only the utility scripts, so the setup instructions do not lead documentation contributors to an unsupported interpreter.
Useful? React with 👍 / 👎.
| Other formats will (as of now) not raise a warning or error, and the project will | ||
| refuse to load in Scratch. | ||
| Scratch only supports MP3 and WAV files. goboscript accepts `.mp3`, `.wav`, and | ||
| `.wave` file extensions and reports an error for unsupported sound formats. |
There was a problem hiding this comment.
When a sound declaration uses a wildcard that matches unsupported files, such as sounds "sounds/*.ogg";, this promise is false: visit_assets in src/visitor/pass0.rs:168-176 silently skips every file for which is_sound_ext returns false, so no asset reaches the InvalidSoundFormat diagnostic in code generation. The build therefore succeeds with the sounds omitted despite this documentation promising an error; either report rejected glob matches or clarify that the error applies only to direct paths.
Useful? React with 👍 / 👎.
1 participant
Correct the documentation examples so declarations and executable statements use valid contexts, keyword function calls compile, and explanations match the compiler's caching, sound validation, macro stringification, and variable namespacing behavior. Update contributor prerequisites, the generated-project tree, and the backdrop block heading.
Advance implicit enum variants after an explicit numeric value. For
A = 2, B,Bnow has value3instead of2.Validation:
git diff --check.cargo check --lockedandcargo test --locked(12 tests passed).sayis uncommented.