Skip to content

Fix tests - #3

Merged
pavog merged 3 commits into
masterfrom
fix-tests
Nov 11, 2025
Merged

pavog merged 3 commits into
masterfrom
fix-tests

Conversation

@pavog

@pavog pavog commented Nov 11, 2025

Copy link
Copy Markdown
Member

Fix tests by using assertEqualsCanonicalizing() to compare arrays of minecraft versions

@pavog
pavog requested a review from JulianVennen November 11, 2025 14:07
Comment thread tests/Integration/Client/ClientTest.php Outdated
@pavog
pavog requested a review from JulianVennen November 11, 2025 15:37

@JulianVennen JulianVennen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although the linked ticket is outdated, that part appears to have been fixed

@pavog
pavog requested a review from JulianVennen November 11, 2025 15:44
@pavog
pavog merged commit 806686a into master Nov 11, 2025
3 checks passed
@pavog
pavog deleted the fix-tests branch November 11, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants