Repository navigation
fix: filter prototype keys in Claude Code transcript and federated peer usage maps (#14658) - #14662
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filters prototype-polluting keys (
__proto__,constructor,prototype) and guards against inherited properties in Claude Code transcript scanning, sanitization, and merge, as well as in federated peer usage ingestion.server/services/claudeCodeTranscriptUsage.js):POLLUTING_KEYSandbucketForfrom../lib/objects.jsto avoid creating or mutating prototype properties duringcollectFile()andscanTranscriptDays().sanitizeTranscriptDays(), skipsPOLLUTING_KEYSin day and model keys.mergeDays(), ensurestarget[model]only checks own properties withObject.hasOwn(target, model)and skipsPOLLUTING_KEYS.server/services/peerUsage.js):sanitizeProviderBucket()andsanitizeActivityBucket(), skips keys matchingPOLLUTING_KEYS.sanitizeActivityMap()andaddInto(), guards againstPOLLUTING_KEYSand inherited properties.server/services/claudeCodeTranscriptUsage.test.jsandserver/services/peerUsage.test.jsverifying that hostile payloads with__proto__,constructor, andprototypeare safely discarded andObject.prototyperemains unpolluted.Closes #14658
Reviews
provider:selection-a6718554da55db6d33801df2(codex[gpt-6.1-terra]): 1 round, clean at 4c0cbd6.