Repository navigation
Restore tray icon for the default controller launch - #587
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Tray Exit cancels integration contexts before hardware cleanup can complete.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Restores the Windows tray icon for the default controller launch by connecting local-primary TUI mode to the existing native-shell lifecycle.
Changes:
- Shares tray startup between TUI and web primaries.
- Adds TUI
--no-tray, Exit handling, and helper-level regression tests. - Updates tray ownership and shortcut documentation.
| File | Description |
|---|---|
| Tools/Controller/README.md | Documents default/TUI tray ownership. |
| Tools/Controller/cmd/controller/native_web_shell.go | Adds the shared tray startup gate. |
| Tools/Controller/cmd/controller/native_web_shell_test.go | Tests default enablement and explicit opt-out. |
| Tools/Controller/cmd/controller/main.go | Wires TUI tray startup, cleanup, and shutdown. |
| docs/Host-Configuration-and-Integrations.md | Clarifies interactive-primary tray behavior. |
| docs/Getting-Started-and-Operations.md | Updates tray options and shortcut launch guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #586. Starts the native tray for the flag-free/default TUI primary through the same lifecycle gate as web mode, prevents duplicate secondary trays, preserves explicit --no-tray, makes tray Exit stop the TUI owner, updates operations docs, and adds enabled-by-default/opt-out regression coverage. Verified with go test ./cmd/controller ./internal/nativeshell and git diff --check.