Repository navigation
Restore contextual TUI reboot and WS2811 controls - #591
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
WS2811 availability, busy-state handling, cursor routing, and reset-state semantics contain unresolved functional issues.
Review effort: Balanced
Findings: 1
Open (6)
Route output controls through semantic row metadata · New Use the healthy connection state for Ctrl+R reset behavior · New Restrict firmware reboot to healthy authenticated connections · New Distinguish hardware reset progress from application reboot · New Render addressable rows independently of relay status · New Disable addressable actions during macro playback or recording · New
What changed in this PR
Restores contextual reboot behavior and adds capability-gated WS2811 controls to the TUI.
Changes:
- Selects firmware reboot online and hardware reset offline.
- Adds configurable WS2811 colors, effects, streaming, and status actions.
- Adds focused TUI regression coverage.
| File | Description |
|---|---|
table.go |
Adds row action and adjustment metadata. |
preview.go |
Enables WS2811 in preview mode. |
pages.go |
Renders WS2811 controls. |
model.go |
Tracks strip settings and contextual reboot actions. |
model_test.go |
Tests reboot and WS2811 behavior. |
interactions.go |
Dispatches contextual reset and strip interactions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Final handoff: merged to main at 1fce120 and deployed from the tested, tree-identical PR head to the canonical Cafe-PC installation. Live verification: authenticated HELLO succeeds, WS2811 status reports a 100-pixel maximum, :8787 returns HTTP 200, and the canonical checkout is clean at origin/main. All six review threads were fixed, replied to, and resolved; required CI passed. Issues #589 and #590 closed automatically. No source-only or unpushed changes remain on Cafe-PC. The deleted local upstream for the older illumination branch is safe: its tree is exactly identical to merged PR #581's squash commit. Ignored local content is reproducible build/cache/deployment output, not unique source. |


Closes #589. Closes #590. Uses authenticated Connected state to select firmware Reboot and reserves DTR HW Reset for offline recovery. Adds a capability-gated, discoverable WS2811 TUI surface with configurable 1..100 pixels, 1..30 FPS rainbow, selectable exact fill colors, effects, clear, stop, and status through the shared command engine. Focused TUI tests and diff checks pass.