Skip to content

Restore contextual TUI reboot and WS2811 controls - #591

Merged
DRSDavidSoft merged 2 commits into
mainfrom
fix/tui-reboot-ws2811
Oct 1, 2026
Merged

DRSDavidSoft merged 2 commits into
mainfrom
fix/tui-reboot-ws2811

Conversation

@DRSDavidSoft

Copy link
Copy Markdown
Collaborator

Closes #589. Closes #590. Uses authenticated Connected state to select firmware Reboot and reserves DTR HW Reset for offline recovery. Adds a capability-gated, discoverable WS2811 TUI surface with configurable 1..100 pixels, 1..30 FPS rainbow, selectable exact fill colors, effects, clear, stop, and status through the shared command engine. Focused TUI tests and diff checks pass.

Copilot AI balanced review requested due to automatic review settings October 1, 2026 21:43
@DRSDavidSoft
DRSDavidSoft enabled auto-merge October 1, 2026 21:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

WS2811 availability, busy-state handling, cursor routing, and reset-state semantics contain unresolved functional issues.

Review effort: Balanced
Findings: 1 High severity · 5 Medium severity

Open (6)
What changed in this PR

Restores contextual reboot behavior and adds capability-gated WS2811 controls to the TUI.

Changes:

  • Selects firmware reboot online and hardware reset offline.
  • Adds configurable WS2811 colors, effects, streaming, and status actions.
  • Adds focused TUI regression coverage.
File Description
table.go Adds row action and adjustment metadata.
preview.go Enables WS2811 in preview mode.
pages.go Renders WS2811 controls.
model.go Tracks strip settings and contextual reboot actions.
model_test.go Tests reboot and WS2811 behavior.
interactions.go Dispatches contextual reset and strip interactions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Tools/Controller/internal/tui/model.go Resolved
Comment thread Tools/Controller/internal/tui/model.go Resolved
Comment thread Tools/Controller/internal/tui/pages.go Resolved
Comment thread Tools/Controller/internal/tui/pages.go Resolved
@DRSDavidSoft
DRSDavidSoft merged commit 1fce120 into main Oct 1, 2026
24 checks passed
@DRSDavidSoft
DRSDavidSoft deleted the fix/tui-reboot-ws2811 branch October 1, 2026 22:09
@DRSDavidSoft

Copy link
Copy Markdown
Collaborator Author

Final handoff: merged to main at 1fce120 and deployed from the tested, tree-identical PR head to the canonical Cafe-PC installation. Live verification: authenticated HELLO succeeds, WS2811 status reports a 100-pixel maximum, :8787 returns HTTP 200, and the canonical checkout is clean at origin/main. All six review threads were fixed, replied to, and resolved; required CI passed. Issues #589 and #590 closed automatically. No source-only or unpushed changes remain on Cafe-PC. The deleted local upstream for the older illumination branch is safe: its tree is exactly identical to merged PR #581's squash commit. Ignored local content is reproducible build/cache/deployment output, not unique source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose WS2811 strip controls in the TUI TUI must show contextual firmware Reboot when authenticated

3 participants