Skip to content

feat(embedded): add password support to the signup flow - #1139

Open
pmathew92 wants to merge 1 commit into
v5_developmentfrom
feat/embedded_signup_password
Open

pmathew92 wants to merge 1 commit into
v5_developmentfrom
feat/embedded_signup_password

Conversation

@pmathew92

@pmathew92 pmathew92 commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Changes

Adds password support to the embedded signup flow, following the server's /e/authorize schemas.

How the flow changes

  • The signup action announces whether the connection collects a password (authentication_methods.password.required). The SDK reports it as Signup.passwordRequirement and keeps it with the session.

  • Once the identifiers are verified, the signup:confirm action carries password_complexity_options. ConfirmSignup.password is null when no password is collected. Otherwise it holds required (carried over from the signup action) and the advisory complexity (minimum length and the character types that are all required).

  • confirmSignup(password) sends the password as given, and an empty string counts as none. The SDK does not validate it, and the server decides. A missing required password, a password sent to a connection that collects none, and a rejected password come back as recoverable InsufficientAuthorization reasons that keep the flow open.

  • access_denied with too_many_resend_attempts is now a terminal TooManyResendAttempts error.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 5ce69b3d-2941-43be-a42e-ee9826d40d31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@pmathew92
pmathew92 marked this pull request as ready for review November 13, 2026 05:08
@pmathew92
pmathew92 requested a review from a team as a code owner November 13, 2026 05:08
@pmathew92 pmathew92 changed the title feat(embedded): add password support to the signup flow [non-main] feat(embedded): add password support to the signup flow Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant