Repository navigation
fix: pin npm to ^11 to avoid broken npm@12 bundled dependencies - #1444
Merged
Merged
Conversation
harshithRai
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Pins the npm version used by the release workflow's publish step on
v4:.github/actions/npm-publish/action.yml:npm install -g npm@latest→npm install -g npm@^11npm@latestnow resolves to npm 12, which requires Node^22.22.2 || ^24.15.0 || >=26.0.0. The publish job runs on Node 20, so the v4.37.2 release failed at this step withEBADENGINE, before anything was published or tagged. npm 11 supports Node^20.17.0 || >=22.9.0, so it works with the current runner.This is the same change as #1367 on
v5. It only affects how the CI job installs npm; no SDK code, endpoints, classes or methods change.After this is merged, the v4.37.2 release can be re-run manually with
workflow_dispatchonv4. The release commit (#1443) is already onv4, and nov4.37.2tag or npm version exists yet.References
Testing
This can't be tested locally, since it only runs inside the release workflow. Checked locally:
npm@^11currently resolves to npm 11.16.0, whoseengines.nodeis^20.17.0 || >=22.9.0, which includes the runner's Node 20.20.2npm@latestinstalls in.githubChecklist