Fix recoverable manifest startup race - #107
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Concurrent gateway startup can no longer observe a partially written recoverable-development manifest.
Root cause
The first process created the final manifest path before writing and syncing its bytes. A losing process could see that path during the write window, read an empty document, and fail JSON parsing. The protected AWS atomic replay run reproduced this under real process contention: auths-dev/auths-field-lab run 31745824077.
Fix
The final manifest remains mode
0600; corrupt completed manifests still fail closed.Validation