fix: ensure graceful shutdown in non-interactive chat mode#181
Merged
Conversation
The --chat mode was falling through without calling the shutdown handler, leaving the session unsaved, GC manager running, and telemetry unflushed. Extracted the shutdown logic into a named runShutdown() function and call it explicitly before process.exit(0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
--chatmode was falling through after the conversation completes without calling the shutdown handler. This left the session unsaved, the GC manager running, and telemetry unflushed. Extracted the shutdown logic into a namedrunShutdown()function and call it explicitly beforeprocess.exit(0).Type of Change
Testing
All existing tests pass. The change extracts existing shutdown logic into a named function (no new behavior introduced) and calls it in the
--chatmode path. No new functions require new unit tests — the existing shutdown handler tests cover the extracted logic.Coverage
Checklist
npm run lintpasses