feat(helm): Add SDK client-side rate limiting to Helm chart templates - #727
feat(helm): Add SDK client-side rate limiting to Helm chart templates#727NicholasBlaskey wants to merge 1 commit into
Conversation
Adds sdkMaxTPS and sdkMaxBurst to the generated Helm chart values and deployment template. When set, the controller passes --sdk-max-tps and --sdk-max-burst flags to the ACK runtime, which wraps the AWS SDK HTTP client with a token bucket rate limiter. This allows operators to cap the controller's AWS API request rate, preventing it from consuming the entire service-level quota. Useful for services with low account-wide rate limits (e.g. Route53 at 5 req/s) where other consumers share the same budget. Values: aws.sdkMaxTPS: 0 # disabled by default, set per-service as needed aws.sdkMaxBurst: 5 # burst allowance for short request bursts Requires ACK runtime >= sdk-rate-limiting.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NicholasBlaskey The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ack-prow
Bot
added
the
needs-ok-to-test
|
Hi @NicholasBlaskey. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
Issue #, if available:
Description of changes: Helm support for aws-controllers-k8s/runtime#264
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.