Skip to content

fix(ci): integ-smoke runs cancel each other across PRs and report the cancellation as a failure #1046

Closed

Description

@isadeks

Describe the bug

integ-smoke turns red on PRs whose integ run never ran.

All integ runs share one job-level concurrency group, cdk-integ. A GitHub concurrency group holds one running job and one waiting job: when another job joins, the one already waiting is cancelled, even with cancel-in-progress: false. Each integ job waits for the deploy environment approval, so whenever two or more PRs finish their build close together, all but the newest are cancelled before anyone can approve them. The report job then posts any result other than success as failure ("integ run cancelled").

Seen on 2026-11-16: ten PRs (#1005–#1015) updated after #1035 merged. Every integ-smoke that showed red was a cancelled job; none of them ran.

Expected behavior

  • Integ runs of different PRs do not cancel each other. A newer commit of the same PR can still supersede that PR's own waiting run.
  • A run that was cancelled before it finished shows as not completed, not as a failed test.

Proposed fix

  • resolve outputs the PR number, and the integ job's group becomes cdk-integ-pr-<number>. Stack names are already run-unique (int-<sha>-<run>), so parallel runs don't collide. The deploy approval stays the gate on how many run at once.
  • report posts pending ("cancelled before it finished; re-run integ for this commit") for a cancelled job and keeps failure for a failed one.

integ-smoke is not a required check, so this only affects what reviewers see.

Activity

  1. added
    approvedWhen an issue has been approved and ready
    bugSomething isn't working
    on Nov 16, 2026
  2. self-assigned this
    on Nov 16, 2026
  3. isadeks commented on Nov 16, 2026

    @isadeks
    ContributorAuthor

    Starting implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

approvedWhen an issue has been approved and readybugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions