Repository navigation
Description
Problem
The security/lint scanner toolchain is pinned to floating latest in mise.toml [tools], so a scanner release can silently change findings between runs. This makes the scheduled security suite non-reproducible and hard to triage — a run can go red with no repo change (e.g. #542's masking count and #593's failing subtask both shifted over time as tools moved).
Current unpinned tools (mise.toml [tools]):
prek = "latest"
gitleaks = "latest"
semgrep = "latest"
osv-scanner = "latest"
grype = "latest"
"aqua:zizmorcore/zizmor" = "latest"
All surfaces are governed by mise.toml (good news)
CI installs these via jdx/mise-action (see security.yml, security-pr.yml, build.yml, etc.), so pinning in mise.toml propagates to all three surfaces at once: local dev, mise run, and CI. No per-workflow duplication to chase. (Exception: build.yml sets MISE_DISABLE_TOOLS=aqua:aquasecurity/trivy,grype,semgrep for that job — those simply aren't installed there; the pins still govern where they DO run.)
Requirements
1. Pin the 6 scanner tools to exact versions in mise.toml [tools] (mirror how knip and the Cedar engines are already exact-pinned). Capture the currently-known-good versions, e.g. at time of writing: semgrep 1.157.0, gitleaks 8.30.1, osv-scanner (current), grype (current), zizmor (current), prek (current) — verify each against a green run before committing.
2. Pin mise itself. Today mise.toml only sets min_version = "2026.2.6" (a floor, not an exact version) — local and CI can drift to different mise releases. Decide and implement one of: (a) tighten to an exact min_version cadence, or (b) document the intended mise version and how it is bumped. Note the existing constraint context: minimum_release_age interplay called out in mise.toml (#320) and jdx/mise#10279 — preserve that reasoning.
3. Bump jdx/mise-action — Dependabot appears to have MISSED this. All workflows pin jdx/mise-action@e6a8b39… # v4.2.0, but latest is v4.2.4 (2026-08-01). .github/dependabot.yml does cover github-actions (package-ecosystem: "github-actions", directory: "/"), so this should have been flagged. As part of this issue: bump the action to v4.2.4 (by pinned SHA) across all workflows, AND investigate why Dependabot didn't open a PR (grouping? schedule? SHA-pin handling?) — fix the config gap so future action drift is caught automatically.
Gotchas
- Pin to versions from a KNOWN-GREEN run, not just "current latest" — pinning to a version that itself surfaces new findings would trade non-reproducibility for a red pin. Coordinate with bug: security:sast:masking fails on main — 6 silent-success-masking findings (unrelated to #532) #542 (masking) and fix(ci): scheduled gitleaks sweep flags unmerged-branch history — scope to main + require per-PR secret check #721 (secrets scope): ideally pin after those land so the baseline is green, or pin to the exact versions that produced the last-green local run and let bug: security:sast:masking fails on main — 6 silent-success-masking findings (unrelated to #532) #542/fix(ci): scheduled gitleaks sweep flags unmerged-branch history — scope to main + require per-PR secret check #721 fix the findings.
semgrepinstall ordering:uvmust be on PATH beforesemgrepinstalls (see the existing comment inmise.toml). Preserve tool ordering/comments.- Exact-pinning
prekmay interact with thecore.hooksPathhook-manager conflict noted in CONTRIBUTING.md — verifymise run hooks:installstill works after pinning. - Bumping
mise-actionby SHA: update BOTH the SHA and the trailing# v4.2.4comment in every workflow (7 files); a mismatch is a lint/readability trap.
Acceptance criteria
- No
= "latest"remains for the 6 scanners inmise.toml; each is an exact version. miseversion strategy is explicit (exact pin or documented bump path), preserving the#320release-age reasoning.- All
jdx/mise-actionreferences are at the same pinned newer version (SHA + comment), and.github/dependabot.ymlis confirmed/fixed to catch action updates going forward. mise run securityreproduces the same findings on two consecutive runs (reproducibility check).- Related toolchain-pinning issue feat(ci): single source of truth for prek↔CI — parameterize scans, pin scanner toolchain, add hook/CI parity contract #329 ("single source of truth for prek↔CI — pin scanner toolchain") — reconcile scope: this issue may satisfy or fold into feat(ci): single source of truth for prek↔CI — parameterize scans, pin scanner toolchain, add hook/CI parity contract #329. Check and cross-link before implementing to avoid duplicate work.
References
#329 (prek↔CI toolchain SoT — likely overlap, reconcile), #320 (mise release-age), #542/#721/#593 (the non-reproducibility symptoms), ADR-003 (governance).
Activity
fix(security): remediate both security:sast findings instead of suppr…
fix(security): clear the two security:sast findings blocking pre-push (…
chore(tooling): enforce the existing quality gates and add missing on…
krokoko commentedon Nov 20, 2026
Triage: what this issue asks for is on
main; a small leftover is noted at the end.Resolved by #1035 (commit
7539ba14): the six scanners, and uv, are exact versions inmise.toml, andCONTRIBUTING.md("Dependency upgrades") says how a pin is bumped; #1052 has since bumped four of them by pull request. Every workflow that installs mise pins release 2026.10.25 (#1035, #1048), the contributor image pins the same release (#1055), andmise run check:mise-version-sync(#1056) fails the build when they differ;min_versionremains a floor for other local installs. All seven workflows that use jdx/mise-action reference one commit of it, the one tagged v5.2.7, a bump Dependabot made in #1039; Dependabot had opened #692 for the 4.2.4 bump on 2026-08-01, four days before this issue, and the github-actions block of.github/dependabot.ymlis unchanged. Left outside this issue: semgrep still downloads its registry rule packs at scan time, tracked in #540, and the hook and CI parity work is tracked in #329.Posted from an automated sweep of the open issues. Each pull request, commit and file named above was checked against
mainat3dbfada1. The issue is left open for a maintainer to close.