Skip to content

25 pre-existing masking findings on main fail the pre-push gate, forcing --no-verify for every contributor #766

Open

Description

@laithalsaadoon

Problem

The masking-findings gate fails on pristine main with 25 pre-existing findings (up from 15 when the #763 work was briefed). Because the gate runs pre-push, every contributor must push with --no-verify to land anything — which also skips every other pre-push check, so the gate's growth is silently eroding the whole hook.

Evidence

Suggested resolution

  1. Triage the 25 findings on main: fix the real ones, suppress false positives with justified nosemgrep annotations.
  2. Once main is clean, the gate becomes meaningful again and --no-verify stops being the default workflow.
  3. Consider a baseline/ratchet mechanism (fail only on new findings) if a full cleanup can't land soon, so the gate blocks regressions without blocking unrelated work.

Origin

Found during PR #763 — see the merge-guidance comment: #763 (comment)

Activity

  1. added
    bugSomething isn't working
    ci-cdBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflows
    on Aug 14, 2026
  2. krokoko commented on Nov 20, 2026

    @krokoko
    Contributor

    Triage: this looks resolved on main.

    Main has no open silent-success-masking finding: the findings were fixed, or suppressed with a rule id and a reason, in #788 (c33befa), #837 (06b3f22), #863 (25330c7), #862 (0ab2c71) and #909 (c8fcdb0), and #756 is closed. mise run security:sast:masking, the leg the pre-push hook runs, passes on main at 3dbfada: 61 findings, all suppressed, and scripts/check-masking-suppression-placement.mjs checks that each suppression sits on a finding. The ratchet suggested here is security:sast:masking:range (#788), and since #1035 (7539ba1) the full scan is also a step of the required check 'Secrets, deps, and workflow scan' (.github/workflows/security-pr.yml), so a pull request with an open finding cannot merge. The agent image scan, the leg of the pre-push suite that failed behind this one, was the subject of #897; its findings are fixed on main as well (#1048, #1052).

    Posted from an automated sweep of the open issues. Each pull request, commit and file named above was checked against main at 3dbfada1. The issue is left open for a maintainer to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingci-cdBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflowstoolingv1Version 1

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions