Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
126 commits
Select commit Hold shift + click to select a range
ec3e909
chore(deps): upgrade the JavaScript workspaces and the tool pins
Nov 17, 2026
c990a97
chore(deps): upgrade the agent's Python dependencies and image pins
Nov 17, 2026
59d23c9
test(tooling): move the AWS Emulator pin to 1.0.489
Nov 17, 2026
dd2ae00
chore(deps): install pip 26.3 in the agent image for the image scan
Nov 17, 2026
e6a780c
fix(agent): set updated_at when the agent changes a task's status
Nov 18, 2026
38649d2
fix(agent): fail task start on a Cedar rule that cannot be evaluated
Nov 18, 2026
26556f4
fix(registry): stop publish stranding records and hiding the reason
Nov 18, 2026
603bcfc
fix(agent): correct the secret scanners and the content sanitizer
Nov 18, 2026
7bf1b4e
fix(api): stop five read endpoints from failing or hiding data
Nov 18, 2026
0fca4c0
fix(agent): keep session-only .mcp.json edits out of pull requests
Nov 18, 2026
ea30566
fix(registry): delete a registry's records before deleting the registry
Nov 18, 2026
9ca911d
fix(api): make confirm-uploads fail closed and safe to repeat
Nov 18, 2026
0930c97
fix(agent): gate a force push written with the flag after the branch
Nov 18, 2026
374c5f5
fix(agent): pick the right branch and repository during repo setup
Nov 18, 2026
73fc75b
fix(cli): make the Linear commands work on a multi-workspace stack
Nov 18, 2026
a3c4172
fix(api): limit what the server behind a URL attachment can do to a task
Nov 18, 2026
32c0724
fix(cli): report a corrupt config as not configured, add missing tests
Nov 18, 2026
7ce97f5
fix(api): bound the secret scan of an oversized deny reason
Nov 18, 2026
379c7fd
docs(tooling): bring the emulator README up to date for 1.0.489
Nov 18, 2026
a33cf11
fix(jira): ignore ABCA's own comments and another site's stored graph
Nov 18, 2026
7217a3c
docs(tooling): say what the MicroVM port answers without credentials
Nov 17, 2026
bbb82f2
fix(hydration): fail a task that cannot run without its issue or PR
Nov 18, 2026
b54cf38
fix(agent): harden run_cmd output handling, timeouts and log redaction
Nov 18, 2026
540720b
fix(slack): keep retried deliveries from losing or repeating messages
Nov 18, 2026
65fdb18
fix(orchestration): stop false timeouts and stray agent sessions
Nov 18, 2026
2195ccb
fix(cli): make --verbose work on subcommands of command groups
Nov 18, 2026
133d020
fix(linear): tell commenters why nothing started and end a reply loop
Nov 18, 2026
fbba1a6
fix(api): make failure titles and retry advice match what failed
Nov 18, 2026
cb45f95
fix(agent): correct what the pipeline reports when a task ends
Nov 18, 2026
d507c1b
fix(agent): make secret redaction of built-in tool output take effect
Nov 18, 2026
7497330
fix(slack): stop taking the first slash word of a mention as repo
Nov 18, 2026
a209155
fix(orchestration): treat temporary GitHub and ECS failures as temporary
Nov 18, 2026
bb37740
fix(hydration): record guardrail blocks and use the repo token for URLs
Nov 18, 2026
027e214
fix(fanout): retry failed notifications and stop false Jira successes
Nov 18, 2026
7d23026
fix(agent): record cost, duration and metrics for a crashed task
Nov 18, 2026
58fb2a9
fix(cli): correct two Linear command reports and delete dead paths
Nov 18, 2026
911131a
fix(linear): keep vault workspaces online, previews on the right issue
Nov 18, 2026
7e91a5a
fix(orchestration): stop the sweep editing every finished epic's panel
Nov 18, 2026
6ab764e
fix(memory): load past task episodes and let the team-budget alarm fire
Nov 18, 2026
2291213
fix(linear): answer a named sub-issue with its state, not a question
Nov 18, 2026
57c5359
chore(tooling): close a lint bypass in cdk, drop 15 duplicate rules
Nov 18, 2026
18c8427
fix(agent): repair local runs and diagnostics, close a coverage bypass
Nov 18, 2026
d2aab81
fix(cdk): deliver nudges on ECS, correct pass rates, redact keys in WAF
Nov 18, 2026
7912cc4
fix(agent): give repo-less tasks their attachments and a cancel check
Nov 18, 2026
4de1352
fix(screenshots): let a branch name only a task of its own repository
Nov 18, 2026
2fe8989
fix(cli): let Linear prompts read a piped answer, test consent guards
Nov 18, 2026
7d6378a
fix(hydration): sanitize a text in time proportional to its length
Nov 18, 2026
dbbb526
fix(jira): stop moving cards backward and show the agent's answers
Nov 18, 2026
ac79d90
fix(api): read auth headers in any casing and log each API key use
Nov 18, 2026
0671fca
fix(cli): share one visible prompt that fails at the end of input
Nov 18, 2026
357dd32
fix(metrics): publish the approval metrics that have no dimensions
Nov 18, 2026
eb0bf68
fix(agent): stop the post-hooks losing commits or failing the task
Nov 18, 2026
a9eaf91
fix(api): refuse malformed task input and let a retried upload finish
Nov 18, 2026
5e2121e
fix(linear): let an admin remove a workspace whose Linear grant died
Nov 18, 2026
9dc79af
fix(orchestration): stop late task events from undoing an epic's repair
Nov 18, 2026
542424b
chore(tooling): tighten the SAST scan, git hooks and coverage gates
Nov 18, 2026
70d8462
fix(agent): record tool results and error reasons, count real turns
Nov 18, 2026
6fdf69d
fix(cli): answer piped prompts from one reader, in their order
Nov 18, 2026
dd81f7a
fix(registry): keep git working in clones with registry MCP servers
Nov 18, 2026
fae72ad
fix(linear): stop telling the agent an attached file is missing
Nov 18, 2026
08f4675
fix(agent): stop failing finished answers over an everyday phrase
Nov 18, 2026
df80036
docs(guides): correct the task requests of the guides and test them
Nov 18, 2026
222d0ea
fix(agent): stop renewing Linear tokens the agent cannot store
Nov 18, 2026
ae54bbc
fix(orchestration): let a reworded or long sub-issue of an epic start
Nov 18, 2026
6882b88
fix(agent): correct the commands and rules the coding prompts give
Nov 18, 2026
c7c9f42
fix(cli): stop reading piped input while no prompt is waiting
Nov 18, 2026
f4ca800
refactor(cli): drop a hand-written JSON walk and two wrapper functions
Nov 18, 2026
9a8ce2e
test(agent): cover the decisions run_task makes around the agent
Nov 18, 2026
aa3492a
test(agent): pin what the runner hands the SDK and records from it
Nov 18, 2026
424c6f8
fix(cli): follow the API's attachment limits and list pagination
Nov 18, 2026
2a61dca
fix(agent): catch a re-clone of the task repository on its own line
Nov 18, 2026
d7240e6
fix(orchestration): run a sub-issue added to an epic after a failure
Nov 18, 2026
87d01d8
chore(cdk): drop dead cdk-nag suppressions, fetch less in registry show
Nov 18, 2026
9847cf3
fix(agent): replace app and bearer tokens whole past an inner marker
Nov 18, 2026
8c3c94f
fix(agent): fail a task whose pinned MCP server the Linear scrub removes
Nov 18, 2026
1d85675
docs: bring the design docs and guides in line with the changed code
Nov 18, 2026
b7e7fce
fix(orchestration): refuse a fork's pull request before a session starts
Nov 18, 2026
7382fe0
refactor(agent): use one hash for approval rows and the deny cache
Nov 18, 2026
6ec017d
fix(cli): make bgagent list follow the page token of the API
Nov 18, 2026
d1ae771
fix(agent): use the shared redactor in the server, drop deprecated calls
Nov 18, 2026
f99f2ea
test(agent): start every test with an empty OpenTelemetry context
Nov 18, 2026
51745ca
fix(linear): write "Task timed out" in the final comment, not timed_out
Nov 18, 2026
c2e37bf
chore(tooling): delete unread .npmignore files and dead scan exemptions
Nov 18, 2026
acdd35e
test(registry): add six cases to the two-language parity corpora
Nov 18, 2026
574168c
fix(api): log an invalid policy set under its own message
Nov 18, 2026
1e626a0
chore(tooling): fail the console lint on dropped and misused promises
Nov 18, 2026
d19cb4c
fix(console): word the last step of a task by what that step does
Nov 18, 2026
34107df
refactor(cdk): one pull request number rule, drop unused channel ops
Nov 18, 2026
12ca550
chore(deps): accept the picomatch advisory, drop an unused ignore
Nov 18, 2026
c24284a
chore(cdk): drop two dead cdk-nag suppressions, correct stale comments
Nov 18, 2026
4088248
fix(agent): fail a task whose pinned MCP server the CLI would skip
Nov 18, 2026
83f232c
chore(tooling): turn on three lint rules, test the complexity records
Nov 18, 2026
c1e70e6
docs: say what a request without a workflow runs, list the fork reason
Nov 18, 2026
bf9c197
fix(tooling): masking gate sees tuple handlers and non-source files
Nov 18, 2026
058f443
fix(agent): keep trace headers and baggage out of third-party requests
Nov 18, 2026
f503a20
fix(api): hide expired approval requests and wire the per-user cap
Nov 18, 2026
dba7b84
docs: regenerate the Starlight mirrors of the changed documents
Nov 18, 2026
5332360
refactor(hydration): show static analysis that the tag pass is repeated
Nov 18, 2026
90b7606
test(api): require the warning when the pending list stops at its cap
Nov 18, 2026
53543e8
chore: bring main's new code and this branch's gates together
Nov 19, 2026
1ee9df0
fix(cli): upload the right file on a retry, report the real failure
Nov 19, 2026
fe323bd
fix(linear): revoke only the installation a workspace removal read
Nov 19, 2026
bb696b5
fix(agent): refuse every fork pull request, flag failed gateway calls
Nov 19, 2026
0218c05
fix(jira): stop iterations pulling cards back, use current overrides
Nov 19, 2026
7045896
fix(agent): gate `git push <ref> -f` before ; & | > 2> or a line break
Nov 19, 2026
3fa0407
chore: correct two documents and drop a dead bundling workaround
Nov 19, 2026
6885203
fix(cli): refuse a Linear slug registered to another workspace
Nov 19, 2026
6d04a11
fix(jira): render the agent's Markdown and name a red build's reason
Nov 19, 2026
51a8811
fix(orchestration): bound failed status reads, contain two failed writes
Nov 19, 2026
23acc40
fix(cli): keep the first-mapped date of Linear and Slack mappings
Nov 19, 2026
061fe37
fix(agent): redact a connection string whose password holds a slash
Nov 19, 2026
7ddfd94
chore: drop a knip entry and say which records #904 raised
Nov 19, 2026
c2ce481
fix(agent): gate `git push -f` whatever follows the flag
Nov 19, 2026
536a1a5
fix(agent): stamp updated_at when a task resumes after an approval
Nov 19, 2026
57c8384
fix(cli): read the active row where two rows carry a Linear slug
Nov 19, 2026
7dd356a
fix(jira): keep operators and links as typed, and a red-build answer
Nov 19, 2026
ba6f73a
docs(agent): name the probed CLI versions, correct two complexity notes
Nov 19, 2026
9e0f987
fix(orchestration): wait out failed status reads, stop a leaked MicroVM
Nov 19, 2026
b6c89a6
docs: drop five stale line references and regenerate the mirrors
Nov 19, 2026
b8f1297
test(agent): hold the emulator tier to the stamp of a resume
Nov 19, 2026
5370273
fix(jira): keep a run of asterisks in the agent's text as typed
Nov 19, 2026
fa89344
fix(agent): redact a URL whose password begins with digits and a slash
Nov 19, 2026
d603d3d
fix(orchestration): drop the ten-poll rule that only a stale read met
Nov 19, 2026
a5112dd
docs(cli): quote the complexity record the setup action has now
Nov 19, 2026
19fd63c
test(agent): hold the port rule of the scanners to the first at sign
Nov 19, 2026
fe2d61c
fix(agent): use the Go module proxy to build gh
Nov 19, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
.gitleaks.toml @aws-samples/coding-agents-admin
.gitleaksignore @aws-samples/coding-agents-admin
.mergify.yml @aws-samples/coding-agents-admin
.npmignore @aws-samples/coding-agents-admin
.pre-commit-config.yaml @aws-samples/coding-agents-admin
.semgrep @aws-samples/coding-agents-admin
.threat-composer @aws-samples/coding-agents-admin
Expand Down
9 changes: 1 addition & 8 deletions .gitleaks.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ paths = [
"^agent/tests/test_output_scanner\\.py$",
]

[[allowlists]]
description = "Mock workload access token in CDK handler tests (not a real credential)."
stopwords = ["wat-opaque-123"]

[[allowlists]]
description = "Test fixture signing secret in Slack verification unit test (not a real credential)."
stopwords = ["test-signing-secret-abc123"]
Expand Down Expand Up @@ -69,10 +65,7 @@ paths = [
# Per-line opt-out for a 12-digit number that is not an account id: end the
# line with a comment `gitleaks:allow -- <reason>`. Use it only on a line that
# holds no identifier, key or token: the marker is built into gitleaks and
# exempts the whole line from every rule, not only from this one. The stopword
# below has no part in it: gitleaks compares a stopword with the reported
# value, here the twelve digits, so this one never matches.
stopwords = ["gitleaks:allow account-id"]
# exempts the whole line from every rule, not only from this one.

[[rules.allowlists]]
# Retired fixture value from PR #733 (#645). On that branch
Expand Down
22 changes: 0 additions & 22 deletions .npmignore

This file was deleted.

32 changes: 19 additions & 13 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,22 @@ repos:

- repo: local
hooks:
# Every entry below that runs a mise task exports MISE_ACTIVATE_AGGRESSIVE=1 first.
# On macOS the login shell of an entry puts /usr/local/bin and /opt/homebrew/bin back
# in front of the directories mise had added to PATH, and mise leaves them there: the
# hook then ran the machine's own node, gitleaks and semgrep, not the versions that
# mise.toml pins. With the variable mise puts its tools first again. A hook added
# here needs it too (cdk/test/scripts/git-hooks.test.ts).
- id: gitleaks
name: gitleaks (staged)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && mise run security:secrets:staged'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_ACTIVATE_AGGRESSIVE=1 && mise run security:secrets:staged'
language: system
pass_filenames: false
stages: [pre-commit]

- id: cdk-eslint
name: eslint (cdk)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && mise //cdk:eslint'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && export MISE_ACTIVATE_AGGRESSIVE=1 && mise //cdk:eslint'
language: system
pass_filenames: false
files: ^cdk/.*\.(ts|tsx|mts|cts|cjs|mjs|js)$
Expand All @@ -43,31 +49,31 @@ repos:

- id: cli-eslint
name: eslint (cli)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && mise //cli:eslint'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && export MISE_ACTIVATE_AGGRESSIVE=1 && mise //cli:eslint'
language: system
pass_filenames: false
files: ^cli/.*\.(ts|tsx|mts|cts|cjs|mjs|js)$
stages: [pre-commit]

- id: web-eslint
name: eslint (web)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && mise //web:eslint'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && export MISE_ACTIVATE_AGGRESSIVE=1 && mise //web:eslint'
language: system
pass_filenames: false
files: ^web/.*\.(ts|tsx|mts|cts|cjs|mjs|js)$
stages: [pre-commit]

- id: agent-quality
name: quality (agent)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)/agent" && mise run quality'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)/agent" && export MISE_ACTIVATE_AGGRESSIVE=1 && mise run quality'
language: system
pass_filenames: false
files: ^agent/.*\.py$
stages: [pre-commit]

- id: docs-sync
name: sync docs → Starlight mirrors
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)/docs" && node scripts/sync-starlight.mjs && git add src/content/docs/'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && export MISE_ACTIVATE_AGGRESSIVE=1 && mise //docs:sync && git add docs/src/content/docs/'
language: system
pass_filenames: false
files: ^(docs/(design|guides)/.*\.md$|CONTRIBUTING\.md$)
Expand All @@ -88,23 +94,23 @@ repos:

- id: docs-markdown-lint
name: markdown structure lint (all tracked Markdown)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && mise //docs:markdown-lint'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && export MISE_ACTIVATE_AGGRESSIVE=1 && mise //docs:markdown-lint'
language: system
pass_filenames: false
files: \.(md|mdx)$
stages: [pre-commit]

- id: docs-script-tests
name: docs script tests (generator, markdown lint)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && mise //docs:test'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_EXPERIMENTAL=1 && export MISE_ACTIVATE_AGGRESSIVE=1 && mise //docs:test'
language: system
pass_filenames: false
files: ^docs/scripts/
stages: [pre-commit]

- id: types-sync-cdk-cli
name: type sync drift (CDK ↔ CLI ↔ web)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && mise run check:types-sync'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_ACTIVATE_AGGRESSIVE=1 && mise run check:types-sync'
language: system
pass_filenames: false
# The script compiles the CDK types file with every module it imports (ten
Expand All @@ -115,7 +121,7 @@ repos:

- id: constants-sync
name: cross-language constants drift (contracts/constants.json)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && mise run check:constants-sync'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_ACTIVATE_AGGRESSIVE=1 && mise run check:constants-sync'
language: system
pass_filenames: false
# The script scans every Python file under agent/src, one CDK consumer and
Expand All @@ -125,7 +131,7 @@ repos:

- id: coverage-thresholds-sync
name: coverage threshold drift (contracts/coverage-thresholds.json)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && mise run check:coverage-thresholds-sync'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_ACTIVATE_AGGRESSIVE=1 && mise run check:coverage-thresholds-sync'
language: system
pass_filenames: false
# Every commit, not a `files` pattern: the script reads the contract, five
Expand All @@ -138,14 +144,14 @@ repos:

- id: monorepo-security-pre-push
name: security scans (pre-push)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && mise run hooks:pre-push:security'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export MISE_ACTIVATE_AGGRESSIVE=1 && mise run hooks:pre-push:security'
language: system
pass_filenames: false
stages: [pre-push]

- id: monorepo-tests-pre-push
name: package tests (pre-push)
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export TMPDIR="${HOME}/.cache/cdk-tmp" && mkdir -p "$TMPDIR" && mise run hooks:pre-push:tests'
entry: bash -lc 'cd "$(git rev-parse --show-toplevel)" && export TMPDIR="${HOME}/.cache/cdk-tmp" && mkdir -p "$TMPDIR" && export MISE_ACTIVATE_AGGRESSIVE=1 && mise run hooks:pre-push:tests'
language: system
pass_filenames: false
stages: [pre-push]
67 changes: 67 additions & 0 deletions .semgrep/silent-success-masking.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,63 @@ def masked_multi_except():
return None


# The handler's type as a tuple, without `as`.
def masked_tuple_except() -> list:
try:
return fetch_items()
except (KeyError, ValueError):
# ruleid: py-silent-success-masking
return []


def masked_tuple_except_with_finally():
try:
return fetch_items()
except (KeyError, ValueError, TypeError):
# ruleid: py-silent-success-masking
return None
finally:
print("done")


# A try statement with an `else:` clause, whatever its handlers.
def masked_with_else() -> list:
try:
items = fetch_items()
except ValueError as exc:
print(exc)
# ruleid: py-silent-success-masking
return []
except (KeyError, TypeError):
# ruleid: py-silent-success-masking
return []
else:
return items


def masked_with_else_and_finally() -> list:
try:
items = fetch_items()
except (KeyError, ValueError):
# ruleid: py-silent-success-masking
return []
else:
return items
finally:
print("done")


# What the `else:` clause returns is the success path, not a fallback.
def ok_return_in_else() -> None:
try:
fetch_items()
except (KeyError, ValueError) as exc:
raise RuntimeError("fetch failed") from exc
else:
# ok: py-silent-success-masking
return None


# A conditional re-raise does not clear the fallthrough default: callers that
# hit the non-fatal path still cannot distinguish failure from empty success.
def masked_conditional_reraise(fatal: bool) -> list:
Expand All @@ -126,6 +183,16 @@ def ok_classify_then_reraise(fetch, is_not_found):
raise # everything else fails closed


def ok_tuple_classify_then_reraise(fetch, is_not_found):
try:
return fetch()
except (KeyError, ValueError) as exc:
if is_not_found(exc):
# ok: py-silent-success-masking
return None
raise


def ok_return_in_try_body(items: list) -> list:
try:
if not items:
Expand Down
30 changes: 13 additions & 17 deletions .semgrep/silent-success-masking.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,53 +105,49 @@ rules:
"# nosemgrep: py-silent-success-masking -- <why callers may safely
treat this failure as an empty success>".
patterns:
# `except ...:` matches every handler head: one type, a tuple of types,
# with or without `as`, a bare except. A try statement matches only a
# pattern that has the same optional clauses (`else:`, `finally:`), hence
# the four shapes.
- pattern-either:
- pattern: |
try:
...
except $EXC:
except ...:
...
return $RET
- pattern: |
try:
...
except $EXC as $E:
...
return $RET
- pattern: |
try:
...
except:
...
return $RET
- pattern: |
try:
...
except $EXC:
except ...:
...
return $RET
finally:
...
- pattern: |
try:
...
except $EXC as $E:
except ...:
...
return $RET
finally:
else:
...
- pattern: |
try:
...
except:
except ...:
...
return $RET
else:
...
finally:
...
# Classify-then-reraise is NOT masking (see the TS twin above): a
# classified return followed by a `raise` on the fallthrough surfaces
# every other error. The order distinguishes it from
# masked_conditional_reraise (raise guarded FIRST, then a masking return).
# The exemption is as narrow as these two patterns: the handler binds the
# error (`as`), the try statement has no `else:` and no `finally:`.
- pattern-not: |
try:
...
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ mise run test:integration # emulator-backed tests of cdk, cli and agent (needs D

Security subtasks: `mise run security:secrets`, `security:sast`, `security:sast:range` (the same rule packs, reporting only the findings a branch adds: the per-PR check), `security:sast:masking`, `security:deps`, `security:retire`, `security:gh-actions`. The secret scans print the rule, file and line of each finding. A 12-digit number that reads as an AWS account id fails them, in tests and workflows too, unless it is an AWS-published placeholder (`123456789012`, `111122223333`, `444455556666`, `000000000000`) or, when it is not an account id, its line carries `gitleaks:allow -- <reason>`. Use that marker only on a line that holds no identifier, key or token: it exempts the whole line from every rule of the secret scan, not only the number. For `security:sast:masking` allowlist intentional fallbacks with an inline `nosemgrep: <rule-id> -- <reason>` comment on the flagged `return` line (or the line immediately above) — the rule anchors on the `return`, so a token placed higher does not bind.

`security:sast:masking` also checks the suppression comments themselves, in every tracked TypeScript, JavaScript and Python file. A line that contains the word `nosemgrep` at all — in any letter case, in a comment or in code, for any rule — must be exactly one suppression of the form `nosemgrep: <rule-id> -- <reason>`; a comment that merely mentions suppressions has to use another word. A suppression of a masking rule must also sit on a finding of that rule, or on the line directly above it: one that suppresses nothing fails the task, so delete it when the code no longer needs it.
`security:sast:masking` also checks the suppression comments themselves, in every tracked file that is not Markdown and not under `.semgrep/`: workflows, Dockerfiles, shell scripts and configuration as well as source files. A line that contains the word `nosemgrep` at all — in any letter case, in a comment or in code, for any rule — must be exactly one suppression of the form `nosemgrep: <rule-id> -- <reason>`; a comment that merely mentions suppressions has to use another word. A suppression of a masking rule must also sit on a finding of that rule, or on the line directly above it: one that suppresses nothing fails the task, so delete it when the code no longer needs it.

Package commands: [cdk/AGENTS.md](./cdk/AGENTS.md), [cli/AGENTS.md](./cli/AGENTS.md), [web/AGENTS.md](./web/AGENTS.md), [agent/AGENTS.md](./agent/AGENTS.md), [docs/AGENTS.md](./docs/AGENTS.md).

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Guidelines:

- One logical change per pull request. Related changes (e.g. a feature + its tests) are fine together; unrelated changes should be separate PRs.
- Every change requires a unit test. Tests live alongside the code they cover (`cdk/test/` mirrors `cdk/src/`, `agent/tests/`, `cli/test/`).
- Follow the code style around you. Linters run automatically on every PR (ESLint for TypeScript, Ruff for Python); an ESLint warning fails the build like an error. `mise //cdk:eslint:check`, `mise //cli:eslint:check` and `mise //web:eslint:check` report findings without rewriting files (the tasks without `:check` apply `--fix`), and `mise run lint` runs the lint and type checks of agent, cdk, cli and web, and the agent's dead-code check, the same way. ESLint also rejects coverage-ignore comments (`istanbul ignore`, `c8 ignore`, `v8 ignore`, `node:coverage`) in cdk, cli and web: test the code, or leave it counted as uncovered.
- Follow the code style around you. Linters run automatically on every PR (ESLint for TypeScript, Ruff for Python); an ESLint warning fails the build like an error. `mise //cdk:eslint:check`, `mise //cli:eslint:check` and `mise //web:eslint:check` report findings without rewriting files (the tasks without `:check` apply `--fix`), and `mise run lint` runs the lint and type checks of agent, cdk, cli and web, and the agent's dead-code check, the same way. ESLint also rejects coverage-ignore comments (`istanbul ignore`, `c8 ignore`, `v8 ignore`, `node:coverage`) in cdk, cli and web, and in the agent `# pragma: no cover` and `# pragma: no branch` have no effect: test the code, or leave it counted as uncovered.
- If you change API types in `cdk/src/handlers/shared/types.ts`, update `cli/src/types.ts` to match, and `web/src/core/api/types.ts` where the console mirrors the type. `mise run check:types-sync` fails the build on drift.
- If you change docs sources (`docs/guides/`, `docs/design/`, `docs/decisions/`, `CONTRIBUTING.md`), run `mise //docs:sync` so generated content stays in sync.
- For significant features, add a design document to `docs/design/`.
Expand Down
8 changes: 8 additions & 0 deletions agent/.trivyignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,11 @@
# the binary: gh keeps only the tokenizer (`govulncheck -mode binary` and `go tool nm`).
# Remove this with the GH_VERSION bump in agent/Dockerfile that brings x/net 0.62.0.
CVE-2026-78661 exp:2026-12-16

# setuptools 70.3.0, path traversal in PackageIndex (CVE-2025-47273), reported for the
# copy that pip vendors (pip/_vendor/vendor.txt). pip ships only pkg_resources from it:
# the module the advisory names, setuptools/package_index.py, is not in the image
# (`find / -name 'package_index*'` prints nothing). On 2026-11-17 pip 26.3, the newest
# release, still vendors 70.3.0. Remove this when the image's pip vendors setuptools
# 78.1.1 or later, or no longer vendors it.
CVE-2025-47273 exp:2026-12-16
Loading
Loading