fix(integ-runner): existing snapshot dir interferes with real deployment#1714
Merged
Conversation
In a recent change to integ-runner, we started reusing the synth output directory upon reading so we don't have to re-synth for every single file we need to read from the synth directory. However, we accidentally left the directory too long, where it started interfering with a synth that actually need to be deployed. Now clean up that directory in between checking the snapshot and doing the actual deployable synth.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
|
Total lines changed 2301 is greater than 1000. Please consider breaking this PR down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent change to integ-runner, we started reusing the synth output directory upon reading so we don't have to re-synth for every single file we need to read from the synth directory.
However, we accidentally left the directory too long, where it started interfering with a synth that actually need to be deployed.
Now clean up that directory in between checking the snapshot and doing the actual deployable synth.
In order to fix this, this had to turn into a giant refactoring of the
integ-runner. Big changes:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license