Skip to content

fix(cli-integ): update tests for upcoming validation changes#1734

Merged
aws-cdk-automation merged 1 commit into
mainfrom
huijbers/update-tests
Jul 17, 2026
Merged

fix(cli-integ): update tests for upcoming validation changes#1734
aws-cdk-automation merged 1 commit into
mainfrom
huijbers/update-tests

Conversation

@rix0rrr

@rix0rrr rix0rrr commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Two changes:

  • The ci=true test now uses an app that doesn't generate CloudFormation-Validate diagnostics at the app level, so we are testing just the CLI behavior and not anything else.
  • We are simplifying the codes in the output report a bit, ("Annotation" instead of "Construct Annotations"), so check for a smaller substring.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Two changes:

- The `ci=true` test now uses an app that doesn't generate
  CloudFormation-Validate diagnostics at the app level, so
  we are testing just the CLI behavior and not anything else.
- We are simplifying the codes in the output report a bit,
  ("Annotation" instead of "Construct Annotations"), so check
  for a smaller substring.
@rix0rrr
rix0rrr requested a review from a team July 17, 2026 08:24
@github-actions github-actions Bot added the p2 label Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.59%. Comparing base (bfa3480) to head (3e0994b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1734      +/-   ##
==========================================
+ Coverage   89.57%   89.59%   +0.01%     
==========================================
  Files          77       78       +1     
  Lines       11758    11790      +32     
  Branches     1651     1655       +4     
==========================================
+ Hits        10532    10563      +31     
- Misses       1197     1198       +1     
  Partials       29       29              
Flag Coverage Δ
suite.unit 89.59% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rix0rrr rix0rrr changed the title fix(cli-integ): update tests for new validation routines fix(cli-integ): update tests for new validation changes Jul 17, 2026
@rix0rrr rix0rrr changed the title fix(cli-integ): update tests for new validation changes fix(cli-integ): update tests for upcoming validation changes Jul 17, 2026
@aws-cdk-automation
aws-cdk-automation added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit e6d4c0b Jul 17, 2026
56 checks passed
@aws-cdk-automation
aws-cdk-automation deleted the huijbers/update-tests branch July 17, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants