fix: cannot debug performance issues of internal projects#1736
Draft
rix0rrr wants to merge 1 commit into
Draft
Conversation
We can see in telemetry that there are many slow projects, but we have little information other than that. It's hard to see what is making projects slow, and they can be slow for many reasons. Plus, our leadership is concerned about slowness of internal Amazon projects. This PR is capturing it if CDK is used at Amazon, sending along the project name. We are using multiple markers: first that we are running on an Amazon machine, by detecting an internal authentication technology, then by parsing proprietary build system tools. This makes it vanishingly unlikely that we will accidentally capture external customer data. (Of course, an external customer could always try to poison the signal by putting fake files in the expected places, but if they wanted to do that they could just post garbage to our telemetry endpoint directly).
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
==========================================
- Coverage 89.59% 89.41% -0.18%
==========================================
Files 78 78
Lines 11790 11838 +48
Branches 1655 1660 +5
==========================================
+ Hits 10563 10585 +22
- Misses 1198 1224 +26
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can see in telemetry that there are many slow projects, but we have little information other than that. It's hard to see what is making projects slow, and they can be slow for many reasons. Plus, our leadership is concerned about slowness of internal Amazon projects.
This PR is capturing it if CDK is used at Amazon, sending along the project name. We are using multiple markers: first that we are running on an Amazon machine, by detecting an internal authentication technology, then by parsing proprietary build system tools. This makes it vanishingly unlikely that we will accidentally capture external customer data. (Of course, an external customer could always try to poison the signal by putting fake files in the expected places, but if they wanted to do that they could just post garbage to our telemetry endpoint directly).
The existence of the systems exposed here, although not advertised publicly, is also not exactly a secret. There are many references to these systems, what they do and how they do it, across the entire internet and on GitHub.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license