Skip to content

fix: cannot debug performance issues of internal projects#1736

Draft
rix0rrr wants to merge 1 commit into
mainfrom
huijbers/internal-amzn-project
Draft

fix: cannot debug performance issues of internal projects#1736
rix0rrr wants to merge 1 commit into
mainfrom
huijbers/internal-amzn-project

Conversation

@rix0rrr

@rix0rrr rix0rrr commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

We can see in telemetry that there are many slow projects, but we have little information other than that. It's hard to see what is making projects slow, and they can be slow for many reasons. Plus, our leadership is concerned about slowness of internal Amazon projects.

This PR is capturing it if CDK is used at Amazon, sending along the project name. We are using multiple markers: first that we are running on an Amazon machine, by detecting an internal authentication technology, then by parsing proprietary build system tools. This makes it vanishingly unlikely that we will accidentally capture external customer data. (Of course, an external customer could always try to poison the signal by putting fake files in the expected places, but if they wanted to do that they could just post garbage to our telemetry endpoint directly).

The existence of the systems exposed here, although not advertised publicly, is also not exactly a secret. There are many references to these systems, what they do and how they do it, across the entire internet and on GitHub.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We can see in telemetry that there are many slow projects, but we have
little information other than that. It's hard to see what is making
projects slow, and they can be slow for many reasons. Plus, our
leadership is concerned about slowness of internal Amazon projects.

This PR is capturing it if CDK is used at Amazon, sending along the
project name. We are using multiple markers: first that we are running
on an Amazon machine, by detecting an internal authentication
technology, then by parsing proprietary build system tools. This makes
it vanishingly unlikely that we will accidentally capture external
customer data.

(Of course, an external customer could always try to poison the signal
by putting fake files in the expected places, but if they wanted to do
that they could just post garbage to our telemetry endpoint directly).
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.41%. Comparing base (e6d4c0b) to head (9e6f1bc).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/telemetry/session.ts 50.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1736      +/-   ##
==========================================
- Coverage   89.59%   89.41%   -0.18%     
==========================================
  Files          78       78              
  Lines       11790    11838      +48     
  Branches     1655     1660       +5     
==========================================
+ Hits        10563    10585      +22     
- Misses       1198     1224      +26     
  Partials       29       29              
Flag Coverage Δ
suite.unit 89.41% <50.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants