chore(toolkit-lib): remove dead orphan helper functions - #1737
Merged
Conversation
Remove three unused exported helpers from the orphan module along with the now-unused PATH_METADATA_KEY import: - findResourcesByPath - findBlockingResources - hasAnyCdkPathMetadata None have any call sites; they were left over from earlier iterations of the orphan feature.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
=======================================
Coverage 89.59% 89.59%
=======================================
Files 78 78
Lines 11790 11790
Branches 1655 1655
=======================================
Hits 10563 10563
Misses 1198 1198
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes three unused exported helpers from the orphan module along with the now unused
PATH_METADATA_KEYimport. All live inpackages/@aws-cdk/toolkit-lib/lib/api/orphan/private/helpers.ts:findResourcesByPathfindBlockingResourceshasAnyCdkPathMetadataNone of these have any call sites, no tests nor are they accessible for programmatic users.
Fixes #
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license