-
Notifications
You must be signed in to change notification settings - Fork 17
feat(sdk): monorepo repository to add new otel plugin package #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7bded69
feat(sdk): monorepo repository to add new otel plugin package
hsilan ef37c92
fix(ci): fix path to generate_same_template.py
hsilan 10431ad
Merge branch 'main' into feat/add-otel-package
SilanHe 095b310
chore: examples is a package, local dependency used
hsilan b1c55ae
feat: dedicated env for development
hsilan 72af430
fix: fix failing tests due to test pollution
hsilan 1e2fba9
feat: update CONTRIBUTING.md for new dev workflow
hsilan 83f4c48
fix: fix formatting + deploy-examples
hsilan ea76a4e
fix: deploy-examples uses local sdk
hsilan 772e5eb
fix: path in examples cli.py
hsilan dbd16e6
chore: remove unnecessary linting
hsilan a6ae0f3
chore: prevent accidental publish of otel package
hsilan 1fa4b2b
fix: integration-tests.yml fix for testing package
hsilan f408db7
fix: checkout testing sdk to packages folder
hsilan cd7cdf9
chore: rename examples package to full name
hsilan a222011
fix: integration test path to testing sdk
hsilan 6adece7
fix: integration-test path to testing sdk
hsilan f50a5ad
chore: remove .coverage file
hsilan 9099434
chore: update references to packages/examples to new name
hsilan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,62 @@ | ||
|
|
||
| #!/bin/sh | ||
|
|
||
| set -e | ||
|
|
||
| hatch run test:cov | ||
| echo SUCCESS: tests + coverage | ||
| REPO_ROOT="$(cd "$(dirname "$0")/../.." && pwd)" | ||
| cd "$REPO_ROOT" | ||
|
|
||
| # --- Core SDK checks --- | ||
| echo "==========================================" | ||
| echo "Running checks for aws-durable-execution-sdk-python" | ||
| echo "==========================================" | ||
|
|
||
| hatch run dev-core:cov | ||
| echo "SUCCESS: tests + coverage (core)" | ||
|
|
||
| hatch run dev-core:typecheck | ||
| echo "SUCCESS: typings (core)" | ||
|
|
||
| # --- OTel SDK checks --- | ||
| echo "==========================================" | ||
| echo "Running checks for aws-durable-execution-sdk-python-otel" | ||
| echo "==========================================" | ||
|
|
||
| hatch run dev-otel:cov | ||
| echo "SUCCESS: tests + coverage (otel)" | ||
|
|
||
| hatch run dev-otel:typecheck | ||
| echo "SUCCESS: typings (otel)" | ||
|
|
||
| # --- Examples checks --- | ||
| echo "==========================================" | ||
| echo "Running checks for examples" | ||
| echo "==========================================" | ||
|
|
||
| hatch run dev-examples:test | ||
| echo "SUCCESS: tests (examples)" | ||
|
|
||
| # --- Formatting / linting (per package) --- | ||
| PACKAGES=( | ||
| "packages/aws-durable-execution-sdk-python" | ||
| "packages/aws-durable-execution-sdk-python-otel" | ||
| "packages/aws-durable-execution-sdk-python-examples" | ||
| ) | ||
|
|
||
| # type checks | ||
| hatch run types:check | ||
| echo SUCCESS: typings | ||
| for package_dir in "${PACKAGES[@]}"; do | ||
| full_path="$REPO_ROOT/$package_dir" | ||
| if [ -d "$full_path" ]; then | ||
| echo "==========================================" | ||
| echo "Running formatting/linting for $package_dir" | ||
| echo "==========================================" | ||
| cd "$full_path" | ||
| hatch fmt | ||
| echo "SUCCESS: linting/fmt ($package_dir)" | ||
| else | ||
| echo "WARNING: $package_dir does not exist, skipping fmt" | ||
| fi | ||
| done | ||
|
|
||
| # static analysis | ||
| hatch fmt | ||
| echo SUCCESS: linting/fmt | ||
| cd "$REPO_ROOT" | ||
|
|
||
| # commit message validation | ||
| # --- Commit message validation --- | ||
| hatch run python .github/scripts/lintcommit.py | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I haven't actually tested this one but it looks quite reasonable. I had to work a little more closely with AI on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking: Shebang is sh
#!/bin/shbut lines 39 and 45 use bash array syntax (PACKAGES=( ... ),"${PACKAGES[@]}").Will fail under dash (the default
/bin/shon Debian/Ubuntu).either amend sheabing to
#!/usr/bin/env bash, or rewrite to sh compliant.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#402