Skip to content

ci: centralize pytest configuration in root #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SilanHe merged 1 commit into from
May 29, 2026
Merged

ci: centralize pytest configuration in root #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/aws-durable-execution-sdk-python-examples/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,6 @@ dependencies = [
[tool.hatch.build.targets.wheel]
packages = ["src"]

[tool.pytest.ini_options]
testpaths = ["test"]
addopts = "-v --strict-markers"
pythonpath = ["."]
markers = [
"example: marks tests as example tests (deselect with '-m \"not example\"')",
"durable_execution: marks tests that use the durable_runner fixture (not used for test selection)",
]

[tool.hatch.envs.examples.scripts]
cli = "python cli.py {args}"
bootstrap = "python cli.py bootstrap"
Expand Down
4 changes: 0 additions & 4 deletions packages/aws-durable-execution-sdk-python-otel/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,3 @@ lines-after-imports = 2
"SIM117",
"TRY301",
]

[tool.pytest.ini_options]
testpaths = ["tests"]
addopts = "-v --strict-markers"
13 changes: 0 additions & 13 deletions packages/aws-durable-execution-sdk-python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,3 @@ lines-after-imports = 2
"SIM117",
"TRY301",
]

[tool.pytest.ini_options]
# Declare custom markers to avoid warnings with --strict-markers
markers = [
# Used for test selection with -m example
"example: marks tests as example tests (deselect with '-m \"not example\"')",
# Used for configuration - passes handler and lambda_function_name to durable_runner fixture
"durable_execution: marks tests that use the durable_runner fixture (not used for test selection)",
]
# Default test discovery paths
testpaths = ["tests"]
# Default options for all test runs
addopts = "-v --strict-markers"
10 changes: 8 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,19 @@ cov = "pytest --cov-report=term-missing --cov {args}"
examples-integration = "pytest --runner-mode=cloud -m example packages/aws-durable-execution-sdk-python-examples/test/ -v {args}"

[tool.pytest.ini_options]
addopts = "--import-mode=importlib"
# Declare custom markers to avoid warnings with --strict-markers
addopts = "-v --strict-markers --import-mode=importlib"
Copy link
Copy Markdown
Contributor

@zhongkechen zhongkechen May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why we need --import-mode=importlib

Copy link
Copy Markdown
Contributor Author

@SilanHe SilanHe May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's because of the new monorepo, if we have tests in 2 packages with the same file name, they will normally collide since the --import-mode is by default prepend. importlib mode uses Python's importlib to import each test file as a unique module based on its full file path, so there's no collision.

https://docs.pytest.org/en/7.1.x/explanation/pythonpath.html

testpaths = [
"packages/aws-durable-execution-sdk-python/tests",
"packages/aws-durable-execution-sdk-python-otel/tests",
"packages/aws-durable-execution-sdk-python-examples/test",
]

markers = [
# Used for test selection with -m example
"example: marks tests as example tests (deselect with '-m \"not example\"')",
# Used for configuration - passes handler and lambda_function_name to durable_runner fixture
"durable_execution: marks tests that use the durable_runner fixture (not used for test selection)",
]

[tool.hatch.envs.types]
workspace.members = ["packages/*"]
Expand Down