Repository navigation
ci: bump golangci-lint to v2.15.0 for Go 1.27 - #650
Open
Yeagerist0 wants to merge 1 commit into
Open
Yeagerist0 wants to merge 1 commit into
Yeagerist0 wants to merge 1 commit into
Conversation
The lint job installs Go with go-version "stable", which is now 1.27.2. golangci-lint v2.13.1 was built with an older Go and cannot read the 1.27 standard library export data, so every run fails with "could not import fmt ... export data version 5 is greater than maximum supported version 4" before it lints anything. v2.15.0 is built with Go 1.27. The newer errcheck also reports the unchecked error received from cmdDone in sigterm_test.go, so log it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
=======================================
Coverage 82.04% 82.04%
=======================================
Files 37 37
Lines 1487 1487
=======================================
Hits 1220 1220
Misses 264 264
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint job fails on every new PR since
go-version: 'stable'moved to Go 1.27.2:golangci-lint v2.13.1 was built with an older Go and can't read 1.27 export data. I reproduced it locally with Go 1.27.2 + v2.13.1, and
golangci-lint runis clean with v2.15.0 (built with go1.27.0) once one finding is fixed: the newer errcheck flags the discarded error from<-cmdDoneinlambda/sigterm_test.go, so the test now logs it.This is why #647, #648 and #649 show a red lint check although their tests pass.
Disclosure: I used Claude Code to help with this; I reproduced the failure and ran the linter myself.