ci: Fix codecov project check on merge to main - #642
Open
fabisev wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
============================================
+ Coverage 65.38% 65.79% +0.40%
- Complexity 213 214 +1
============================================
Files 34 34
Lines 991 991
Branches 143 143
============================================
+ Hits 648 652 +4
+ Misses 290 287 -3
+ Partials 53 52 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
darklight3it
approved these changes
Aug 26, 2026
darklight3it
left a comment
Collaborator
There was a problem hiding this comment.
I think it's fine, only add the permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Problem
Some merges to main fail
codecov/projecteven when the merged tree is unchanged. Last case (PR #629): "65.38% (-0.41%) compared to 7b484d3" (a drop on a tree that is byte-for-byte identical to the PR branch tip).Root cause
PR builds upload coverage from two native matrix runners (x86_64 + aarch64), which Codecov merges into a union. Merge-to-main uploaded a single x86 report, so the merge commit measured slightly less coverage than its own base. With no
codecov.yml, the default project status fails on any drop.Codecov docs:
Fix
.codecov.yml(new):project.threshold: 1%: tolerate sub-1% noise.patch: off: project coverage is the gate.carryforward: true: Codecov's recommended remedy for commits that don't re-upload every report (https://docs.codecov.com/docs/carryforward-flags).Workflows:
flags: ${{ matrix.arch }}+ explicit JaCoCo path.coveragematrix job so main and PR record the same union of reports (also gives carryforward a real per-arch baseline).Result
Merges compare the union of both archs against a like-for-like base, so measurement noise no longer fails the build.
Target (OCI, Managed Runtime, both):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.