aws-cpp-sdk-s3-crt: raise error when failing to write download data#3825
Open
aws-cpp-sdk-s3-crt: raise error when failing to write download data#3825
Conversation
Contributor
Author
Log output after applying this patchWith my failing download and this patch, I am now seeing this in the logs: [ERROR] 2026-05-08 19:54:41.884 S3CrtClient [139836522079808] Failed to write download data
[ERROR] 2026-05-08 19:54:41.884 S3MetaRequest [139836522079808] id=0x7f2e44c62400 Response body callback raised error 59 (Failed writing to file.). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
S3CrtClientneither logs nor raises an error when failing to write download data.To avoid the problem of silent failure, check the
failbit/badbitafter the calls towrite()andflush().Raise and log the error cause.
Return
AWS_OP_ERRto mark the download as failed.Resolves #3824.
Tested on Linux/ubuntu 22.04.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.