Skip to content

Pr 3825 #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbiscigl merged 2 commits into from
May 11, 2026
Merged

Pr 3825 #3826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51d859f
aws-cpp-sdk-s3-crt: raise error when failing to write download data
grrtrr May 8, 2026
be8baa2
added codegen
sbiscigl May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions generated/src/aws-cpp-sdk-s3-crt/source/S3CrtClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,11 @@ int S3CrtClient::S3CrtRequestGetBodyCallback(struct aws_s3_meta_request* meta_re
if (userData->request->IsEventStreamRequest()) {
bodyStream.flush();
}
if (bodyStream.fail()) {
AWS_LOGSTREAM_ERROR(ALLOCATION_TAG, "Failed to write download data");
aws_raise_error(AWS_ERROR_FILE_WRITE_FAILURE);
return AWS_OP_ERR;
}

// Replenish flow-control window (no-op if enable_read_backpressure is not set):
aws_s3_meta_request_increment_read_window(meta_request, body->len);
Expand Down
5 changes: 5 additions & 0 deletions ...s/com/amazonaws/util/awsclientgenerator/velocity/cpp/s3/s3-crt/S3CrtSpecificOperations.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ int S3CrtClient::S3CrtRequestGetBodyCallback(struct aws_s3_meta_request *meta_re
{
bodyStream.flush();
}
if (bodyStream.fail()) {
AWS_LOGSTREAM_ERROR(ALLOCATION_TAG, "Failed to write download data");
aws_raise_error(AWS_ERROR_FILE_WRITE_FAILURE);
return AWS_OP_ERR;
}

// Replenish flow-control window (no-op if enable_read_backpressure is not set):
aws_s3_meta_request_increment_read_window(meta_request, body->len);
Expand Down
5 changes: 5 additions & 0 deletions ...amazonaws/util/awsclientgenerator/velocity/cpp/s3/s3-crt/SmithyS3CrtSpecificOperations.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ int S3CrtClient::S3CrtRequestGetBodyCallback(struct aws_s3_meta_request *meta_re
{
bodyStream.flush();
}
if (bodyStream.fail()) {
AWS_LOGSTREAM_ERROR(ALLOCATION_TAG, "Failed to write download data");
aws_raise_error(AWS_ERROR_FILE_WRITE_FAILURE);
return AWS_OP_ERR;
}

// Replenish flow-control window (no-op if enable_read_backpressure is not set):
aws_s3_meta_request_increment_read_window(meta_request, body->len);
Expand Down
Loading