Skip to content

[Bugfix] - codegen to use serviceId#3828

Merged
kai-ion merged 5 commits into
mainfrom
smithyCodegen
May 12, 2026
Merged

[Bugfix] - codegen to use serviceId#3828
kai-ion merged 5 commits into
mainfrom
smithyCodegen

Conversation

@kai-ion
Copy link
Copy Markdown
Collaborator

@kai-ion kai-ion commented May 12, 2026

Issue #, if available:

Description of changes:
When a service's Smithy sdkId normalizes
to a different name than the C2J filename prefix the
Smithy pagination/waiters codegen fails to match the service or writes files
to the wrong path. Previously this required a manual entry in the map file.

New services will now create files with serviceId matching smithy

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kai-ion kai-ion enabled auto-merge May 12, 2026 20:07
@kai-ion kai-ion changed the title [Bugfix] - Auto-update smithy2c2j_service_map.json [Bugfix] - codegen to use serviceId May 12, 2026
@kai-ion kai-ion added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit 09544c6 May 12, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants