Repository navigation
Remove deprecated S3 encryption clients, replaced credentials providers and unused code #4002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
averyk22
wants to merge
3
commits into
release/1.12
Choose a base branch
from
remove-deprecated-apis
base: release/1.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+174
−2,017
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
.changelog/breaking-change-remove-replaced-credentials-providers.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "breaking-change", | ||
| "category": "aws-cpp-sdk-core", | ||
| "contributor": "averyk22", | ||
| "description": "Remove ProcessCredentialsProvider and the original ProfileConfigFileAWSCredentialsProvider, which the default chain stopped using once the CRT-backed ProfileCredentialsProvider took over their work. ProfileConfigFileAWSCredentialsProvider still compiles as a deprecated alias of ProfileCredentialsProvider; use ProfileCredentialsProvider for credential_process too. Unlike the old provider, ProfileCredentialsProvider reads the config and credentials files once when it is created; its refreshRateMs is ignored, so keys rotated in the files are picked up only by a new provider. It also follows the shared config file format strictly: a line that starts with whitespace continues the previous property, so a profile line indented by mistake can stop the file from loading. Requests using credential_process now report the profile credentials feature in the user agent instead of the process credentials feature. AWSCredentialsProvider.h no longer includes GeneralHTTPCredentialsProvider.h; include it directly to use GeneralHTTPCredentialsProvider or TaskRoleCredentialsProvider." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "breaking-change", | ||
| "category": "aws-cpp-sdk-s3-encryption", | ||
| "contributor": "averyk22", | ||
| "description": "Remove the deprecated S3EncryptionClient and S3EncryptionClientV2, along with CryptoConfigurationV2. Use S3EncryptionClientV3 with CryptoConfigurationV3; call AllowLegacy() on the configuration to keep reading objects the older clients wrote. S3EncryptionClientBase's constructors are now protected, so the base client can no longer be built directly with legacy encryption settings." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "breaking-change", | ||
| "category": "aws-cpp-sdk-core", | ||
| "contributor": "averyk22", | ||
| "description": "Remove code the SDK never used: Aws::Utils::GetTheLights, the aws/core/utils/memory/stl/AWSMultiMap.h header and aws/core/external/CommonCryptorSPI.h. Aws::MultiMap is still available from aws/core/utils/memory/stl/AWSMap.h." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "bugfix", | ||
| "category": "aws-cpp-sdk-core", | ||
| "contributor": "averyk22", | ||
| "description": "CRT-backed credentials providers, including ProfileCredentialsProvider in the default chain, now return the account ID from aws_account_id in the profile and AccountId in credential_process output. Without it, DynamoDB fell back from account-based endpoints to the regional endpoint, and accountIdEndpointMode=required failed." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "bugfix", | ||
| "category": "aws-cpp-sdk-core", | ||
| "contributor": "averyk22", | ||
| "description": "ProfileCredentialsProvider's default constructor, used by the default credentials chain, now picks its profile the same way as the rest of the SDK: AWS_DEFAULT_PROFILE, then AWS_PROFILE, then default. It previously ignored AWS_DEFAULT_PROFILE, so credentials and settings like the region could come from different profiles." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refresh: documented, not changed:
refreshRateMsis ignored andReload()is empty. The CRT reads the files once, and static keys never expire, so rotated keys need a new provider. Expiring credentials still refresh. Re-reading the files would be a behavior change, so this PR only documents it. Also note:DEFAULT_REFRESH_RATE_MSin the.cppis really the CRT fetch timeout, not a refresh rate.