Repository navigation
fix(proxy): Require connection token for port proxy requests - #313
Merged
Merged
Conversation
When connection token auth is enabled, the port forwarding proxy requires the connection token for /ports/ and /absports/ (HTTP and WebSocket) and returns 403 otherwise. The vscode-tkn cookie is now HttpOnly and Secure; the server passes the token to the workbench through its configuration. Servers started with --without-connection-token are unchanged.
skazantsev
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Update the proxy server patch (
web-server/proxy-uri.diff) so proxied port requests use the same connection token as the workbench.Changes:
/ports/and/absports/requests (HTTP and WebSocket); respond 403 otherwise--without-connection-tokenare unchangedHttpOnlyandSecureon thevscode-tkncookie (SameSite=Laxas before); pass the token to the workbench through its configuration\r\n\r\nTesting
prepare-src.shforcode-editor-serverandcode-editor-sagemaker-serverBy submitting this pull request, I confirm that you can use, modify, copy,
and redistribute this contribution, under the terms of your choice.