Repository navigation
fix: Stabilize integration cluster tests - #469
Merged
Merged
Conversation
mohamedzeidan2021
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
This change stabilizes the HyperPod CLI integration tests and adds compatibility with Kubernetes Python client 37.
The failures had two independent causes:
default/fsx-claimcluster fixture. That claim’s backing FSx volume could no longer mount after cluster software upgrades, leaving the recipe pod inPending/ContainerCreating. The test initially reported this indirectly asget-logsandexecfailures._metadatapagination field, obsolete model constructor arguments, and invalid unit-test fixture values.Recipe integration test
The existing recipe test now:
FSX_ID.DescribeFileSystemsto retrieve the filesystem’s DNS name, Lustre mount name, and capacity instead of hard-coding environment-specific values.claimName: fsx-claim, then replaces only that temporary template reference with the run-specific PVC.Retainand never creates, modifies, or deletes the underlying FSx filesystem.This preserves the original
init → configure → validate → create → logs/exec → deleteworkflow while removing dependence on mutable cluster-level PV/PVC fixtures.The CI execution role requires the read-only
fsx:DescribeFileSystemspermission to resolve the filesystem metadata associated withFSX_ID.Kubernetes client compatibility
The
list-clusterimplementation now:ApiClientfor each temporary cluster kubeconfig instead of changing process-global Kubernetes configuration from parallel workers.KubernetesClientsingleton behavior for normal callers.ListPods.list_pods_and_get_requested_resources_group_by_node_name()signature by using private client-injection helpers internally.response.metadataproperty instead of the removed privateresponse._metadatafield.Without the pagination change, Kubernetes 37 raised: