Repository navigation
fix(mlops): support StepCollection in the pipeline steps compiler - #6441
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
AkshayShah03
had a problem deploying
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Error
AkshayShah03
had a problem deploying
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Error
AkshayShah03
had a problem deploying
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Error
The v3 StepsCompiler dropped the StepCollection handling the v2 compiler
had: _simplify_step_list raised ValueError('Invalid input step type') for a
StepCollection, and _generate_step_map did not register its sub-steps. As
a result Pipeline(steps=[MonitorBatchTransformStep(...)]) (still a
StepCollection), depends_on=[collection] and depends_on=['collection name']
all failed to build, although Step.depends_on still documents
StepCollection.
Restore the v2 behaviour: flatten a StepCollection into its sub-steps and
register them in the step map.
AkshayShah03
force-pushed
the
fix/steps-compiler-step-collection
branch
from
October 16, 2026 14:11
d8b28aa to
09f7146
Compare
AkshayShah03
requested a deployment
to
manual-approval
October 16, 2026 14:11 — with
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 16, 2026 14:11 — with
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 16, 2026 14:11 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The v3
StepsCompilerdropped theStepCollectionhandling the v2 compiler had:_simplify_step_listraisesValueError: Invalid input step type: <class '...StepCollection'>for aStepCollection;_generate_step_mapdoesn't register its sub-steps.As a result these all fail to build, even though
Step.depends_onstill documentsStepCollection:Pipeline(steps=[MonitorBatchTransformStep(...)])(MonitorBatchTransformStepis still aStepCollection);depends_on=[collection];depends_on=["collection name"].This change restores the v2 behaviour: a
StepCollectionis flattened into its sub-steps, and they're registered in the step map.step_collectionsonly importssteps, so the new import doesn't introduce a cycle.Testing:
TestStepCollectionSupport: a collection insteps, anddepends_ona collection by object and by name. All 3 fail before this change.sagemaker-mlops/tests/unit: 835 passed (832 on master). The 28feature_processorcollection errors also happen on master.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.