Repository navigation
Conversation
Bump the 0.38.0 tag_prefix in djl-lmi.json from 0.38.0-lmi29.0.0-cu130 to 0.38.0-lmi30.0.0-cu130, and register the new tag in KNOWN_MISSING_COMBINATIONS (ap-east-2) as for earlier LMI releases. DJL Serving stays at 0.38.0, so the existing key is edited in place. The registries map and version_aliases are unchanged.
|
The tag bump itself looks right, but I think the two halves of this PR contradict each other and it's worth settling before merge. On this branch,
So which is it?
For reference, I checked the manifest directly ( Worth noting that PR Checks won't answer this either way: the DJL image-URI tests are static assertions over the same JSON they read, so nothing in CI verifies that a tag actually exists in ECR. |
There was a problem hiding this comment.
🤖 AI code review
This PR bumps the DJL-LMI 0.38.0 image tag_prefix from lmi29.0.0-cu130 to lmi30.0.0-cu130 for sagemaker-core (SDK v3.x) and registers the new tag in the test KNOWN_MISSING_COMBINATIONS for ap-east-2. Since DJL Serving stays at 0.38.0, editing the existing version key in place (rather than adding a new key) is correct and matches the established pattern. The change is clean and consistent with prior LMI bump precedent (e.g. PR #6301, #5976).
Reviewed commit c55261e. Automated review; verify before acting.
| # Known missing framework:version:region combinations that don't exist in ECR | ||
| KNOWN_MISSING_COMBINATIONS = { | ||
| "djl-lmi": { | ||
| "0.38.0-lmi30.0.0-cu130": {"ap-east-2"}, |
There was a problem hiding this comment.
🟡 Low: The 0.38.0-lmi29.0.0-cu130 entry is now stale: after this PR the 0.38.0 config key resolves to the lmi30.0.0-cu130 tag, so no test will ever look up the lmi29 combination. It's harmless to leave it, but you could remove it to keep KNOWN_MISSING_COMBINATIONS aligned with what the config actually produces.
The 3.x 0.38.0 registries map includes ap-east-2, so exempting 0.38.0-lmi30.0.0-cu130 there removes nothing from the expected set. The 0.38.0-lmi29.0.0-cu130 key is no longer produced by any tag_prefix.
Summary
Updates the DJL-LMI image config to the newly released LMI v30 (
0.38.0-lmi30.0.0-cu130, DJL Serving 0.38.0 / vLLM 0.31.0) for SageMaker Python SDK 3.x (sagemaker-core). DJL Serving stays at 0.38.0, so this edits the0.38.0key in place and theregistriesmap is unchanged.Changes
sagemaker-core/src/sagemaker/core/image_uri_config/djl-lmi.json: bump the0.38.0tag_prefixfrom0.38.0-lmi29.0.0-cu130to0.38.0-lmi30.0.0-cu130sagemaker-core/tests/unit/image_uris/test_djl.py: register0.38.0-lmi30.0.0-cu130inKNOWN_MISSING_COMBINATIONS(ap-east-2), consistent with prior versionsTesting
pytest tests/unit/image_uris/test_djl.pyinsagemaker-core: 8 passed on Python 3.10 and 3.12image_uris.retrieve("djl-lmi", region="us-west-2", version="0.38.0")andversion="latest"both return763104351884.dkr.ecr.us-west-2.amazonaws.com/djl-inference:0.38.0-lmi30.0.0-cu130; the0.36.0key still returns thelmi27tag